Remove Arista products from sku-sensors-data.yml#9415
Merged
lipxu merged 1 commit intosonic-net:masterfrom Aug 16, 2023
Merged
Conversation
The `platform_tests/test_sensors.py` rely on the information provided in this config file to check for the existance of sysfs paths. This test was introduced before the Platform API existed and did have some purpose then. However all SONiC platform daemons now rely on the Platform API which is tested by numerous tests under `platform_tests`. There is no longer a need to hardcode sysfs paths for products. Keeping this data there is bound to generate recurring issues in the future and translate directly into maintenance burden. Some sysfs paths are just not deterministic. They will depend on which driver is loaded first and whatnot which is inherently flaky for a test to rely on.
Contributor
|
Tried it on 7060device, |
lipxu
approved these changes
Aug 16, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 16, 2023
The `platform_tests/test_sensors.py` rely on the information provided in this config file to check for the existance of sysfs paths. This test was introduced before the Platform API existed and did have some purpose then. However all SONiC platform daemons now rely on the Platform API which is tested by numerous tests under `platform_tests`. There is no longer a need to hardcode sysfs paths for products. Keeping this data there is bound to generate recurring issues in the future and translate directly into maintenance burden. Some sysfs paths are just not deterministic. They will depend on which driver is loaded first and whatnot which is inherently flaky for a test to rely on.
Collaborator
|
Cherry-pick PR to 202205: #9500 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 16, 2023
The `platform_tests/test_sensors.py` rely on the information provided in this config file to check for the existance of sysfs paths. This test was introduced before the Platform API existed and did have some purpose then. However all SONiC platform daemons now rely on the Platform API which is tested by numerous tests under `platform_tests`. There is no longer a need to hardcode sysfs paths for products. Keeping this data there is bound to generate recurring issues in the future and translate directly into maintenance burden. Some sysfs paths are just not deterministic. They will depend on which driver is loaded first and whatnot which is inherently flaky for a test to rely on.
Collaborator
|
Cherry-pick PR to 202305: #9501 |
Collaborator
|
@Staphylo PR conflicts with 202012 branch |
This was referenced Aug 16, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Aug 17, 2023
The `platform_tests/test_sensors.py` rely on the information provided in this config file to check for the existance of sysfs paths. This test was introduced before the Platform API existed and did have some purpose then. However all SONiC platform daemons now rely on the Platform API which is tested by numerous tests under `platform_tests`. There is no longer a need to hardcode sysfs paths for products. Keeping this data there is bound to generate recurring issues in the future and translate directly into maintenance burden. Some sysfs paths are just not deterministic. They will depend on which driver is loaded first and whatnot which is inherently flaky for a test to rely on.
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Aug 17, 2023
The `platform_tests/test_sensors.py` rely on the information provided in this config file to check for the existance of sysfs paths. This test was introduced before the Platform API existed and did have some purpose then. However all SONiC platform daemons now rely on the Platform API which is tested by numerous tests under `platform_tests`. There is no longer a need to hardcode sysfs paths for products. Keeping this data there is bound to generate recurring issues in the future and translate directly into maintenance burden. Some sysfs paths are just not deterministic. They will depend on which driver is loaded first and whatnot which is inherently flaky for a test to rely on.
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
Staphylo
added a commit
to Staphylo/sonic-mgmt
that referenced
this pull request
Aug 21, 2023
The `platform_tests/test_sensors.py` rely on the information provided in this config file to check for the existance of sysfs paths. This test was introduced before the Platform API existed and did have some purpose then. However all SONiC platform daemons now rely on the Platform API which is tested by numerous tests under `platform_tests`. There is no longer a need to hardcode sysfs paths for products. Keeping this data there is bound to generate recurring issues in the future and translate directly into maintenance burden. Some sysfs paths are just not deterministic. They will depend on which driver is loaded first and whatnot which is inherently flaky for a test to rely on.
3 tasks
Contributor
Author
lipxu
pushed a commit
that referenced
this pull request
Aug 21, 2023
The `platform_tests/test_sensors.py` rely on the information provided in this config file to check for the existance of sysfs paths. This test was introduced before the Platform API existed and did have some purpose then. However all SONiC platform daemons now rely on the Platform API which is tested by numerous tests under `platform_tests`. There is no longer a need to hardcode sysfs paths for products. Keeping this data there is bound to generate recurring issues in the future and translate directly into maintenance burden. Some sysfs paths are just not deterministic. They will depend on which driver is loaded first and whatnot which is inherently flaky for a test to rely on.
Contributor
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
The `platform_tests/test_sensors.py` rely on the information provided in this config file to check for the existance of sysfs paths. This test was introduced before the Platform API existed and did have some purpose then. However all SONiC platform daemons now rely on the Platform API which is tested by numerous tests under `platform_tests`. There is no longer a need to hardcode sysfs paths for products. Keeping this data there is bound to generate recurring issues in the future and translate directly into maintenance burden. Some sysfs paths are just not deterministic. They will depend on which driver is loaded first and whatnot which is inherently flaky for a test to rely on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The
platform_tests/test_sensors.pyrely on the information provided in this config file to check for the existance of sysfs paths.This test was introduced before the Platform API existed and did have some purpose then. However all SONiC platform daemons now rely on the Platform API which is tested by numerous tests under
platform_tests.There is no longer a need to hardcode sysfs paths for products. Keeping this data there is bound to generate recurring issues in the future and translate directly into maintenance burden.
Some sysfs paths are just not deterministic. They will depend on which driver is loaded first and whatnot which is inherently flaky for a test to rely on.
Summary: Remove Arista products from sku-sensors-data.yml
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Reduce unreliability and maintenance burden on features that are already covered by Platform API tests
How did you do it?
Removed Arista devices from
sku-sensors-data.ymlHow did you verify/test it?
Ran the test and ensured it is now marked as
SKIPPEDAny platform specific information?
Only concerning Arista devices