Skip to content

Update nic_simulator.py to avoid errors when retrieving packet_filter variable#9412

Closed
svelamal wants to merge 5 commits intosonic-net:masterfrom
svelamal:nic_simulator
Closed

Update nic_simulator.py to avoid errors when retrieving packet_filter variable#9412
svelamal wants to merge 5 commits intosonic-net:masterfrom
svelamal:nic_simulator

Conversation

@svelamal
Copy link
Contributor

Description of PR

Class variable slots does not include packet_filter and drop instances which are accessed later. This causes the nic-simulator to not run successfully and add-topo on Active-Active topology does not work
Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • [x ] 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@svelamal svelamal closed this Aug 10, 2023
@svelamal svelamal deleted the nic_simulator branch August 10, 2023 21:39
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
$(results)

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants