Skip to content

Fix if-state testcase in test_events #9406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbud-msft merged 3 commits into from
Aug 15, 2023
Merged

Fix if-state testcase in test_events #9406

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16531e3
Perform test on valid interfaces
zbud-msft Aug 10, 2023
0c124cb
Shut down only one interface not multiple
zbud-msft Aug 10, 2023
f83aa9b
Fix precommit check
zbud-msft Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions tests/telemetry/events/swss_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
logger = logging.getLogger(__name__)
tag = "sonic-events-swss"

IF_STATE_TEST_PORT = "Ethernet0"
PFC_STORM_TEST_PORT = "Ethernet4"
PFC_STORM_TEST_QUEUE = "4"
PFC_STORM_DETECTION_TIME = 100
Expand All @@ -31,15 +30,17 @@ def test_event(duthost, gnxi_path, ptfhost, data_dir, validate_yang):


def shutdown_interface(duthost):
logger.info("Shutting down an interface")
ret = duthost.shell("config interface startup {}".format(IF_STATE_TEST_PORT))
assert ret["rc"] == 0, "Failing to startup interface {}".format(IF_STATE_TEST_PORT)
logger.info("Shutting down interface")
interfaces = duthost.get_interfaces_status()
if_state_test_port = next((interface for interface, status in interfaces.items()
if status["oper"] == "up" and status["admin"] == "up"), None)
assert if_state_test_port is not None, "Unable to find valid interface for test"

ret = duthost.shell("config interface shutdown {}".format(IF_STATE_TEST_PORT))
assert ret["rc"] == 0, "Failing to shutdown interface {}".format(IF_STATE_TEST_PORT)
ret = duthost.shell("config interface shutdown {}".format(if_state_test_port))
assert ret["rc"] == 0, "Failing to shutdown interface {}".format(if_state_test_port)

ret = duthost.shell("config interface startup {}".format(IF_STATE_TEST_PORT))
assert ret["rc"] == 0, "Failing to startup interface {}".format(IF_STATE_TEST_PORT)
ret = duthost.shell("config interface startup {}".format(if_state_test_port))
assert ret["rc"] == 0, "Failing to startup interface {}".format(if_state_test_port)


def generate_pfc_storm(duthost):
Expand Down