lag_test: Add check to verify that an initial LACP packet was received#9343
Merged
yxieca merged 1 commit intosonic-net:masterfrom Aug 14, 2023
Merged
Conversation
In the LacpTimingTest class, when getting the initial LACP packet, first check to see that a packet was captured before trying to convert the timestamp value of the tuple to a float. Otherwise, there'll be an error about an invalid argument to float. This doesn't necessarily prevent an error from being thrown, it just makes it a more graceful/expected failure. Signed-off-by: Saikrishna Arcot <[email protected]>
yxieca
approved these changes
Aug 14, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
sonic-net#9343) In the LacpTimingTest class, when getting the initial LACP packet, first check to see that a packet was captured before trying to convert the timestamp value of the tuple to a float. Otherwise, there'll be an error about an invalid argument to float. This doesn't necessarily prevent an error from being thrown, it just makes it a more graceful/expected failure. Signed-off-by: Saikrishna Arcot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
If, for some reason, the LAG session is down and there are no LACP PDU packets being sent back and forth, then the
LacpTimingTestclass will fail with a error about an invalid argument tofloat.How did you do it?
In the LacpTimingTest class, when getting the initial LACP packet, first check to see that a packet was captured before trying to convert the timestamp value of the tuple to a
float.This doesn't necessarily prevent an error from being thrown, it just makes it a more graceful/expected failure.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation