[action] [PR:9054] Leave 1 ACL rule in test_crm.py::test_acl_entry#9272
Merged
mssonicbld merged 1 commit intosonic-net:202305from Aug 5, 2023
Merged
[action] [PR:9054] Leave 1 ACL rule in test_crm.py::test_acl_entry#9272mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld merged 1 commit intosonic-net:202305from
Conversation
Some platforms (like broadcom-dnx) allocate ACL banks dynamically so if there are no ACL rules it returns a NULL value for CRM purposes. So leave 1 ACL rule when comparing the returned used/available CRM values. Also on broadcom-dnx an ACL entry is used per bind point so account for that when calculating the expected available acl entries. Summary: Fixes sonic-net#8812 Type of change Test case(new/improvement) Back port request 202205 202305
3 tasks
Collaborator
Author
|
Original PR: #9054 |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some platforms (like broadcom-dnx) allocate ACL banks dynamically so if there are no ACL rules it returns a NULL value for CRM purposes. So leave 1 ACL rule when comparing the returned used/available CRM values.
Also on broadcom-dnx an ACL entry is used per bind point so account for that when calculating the expected available acl entries.
Summary:
Fixes #8812
Type of change
Back port request