Skip to content

Cisco-8000 psu led support#9264

Merged
kevinskwang merged 1 commit intosonic-net:masterfrom
spilkey-cisco:spilkey/psu_led
Aug 28, 2023
Merged

Cisco-8000 psu led support#9264
kevinskwang merged 1 commit intosonic-net:masterfrom
spilkey-cisco:spilkey/psu_led

Conversation

@spilkey-cisco
Copy link
Contributor

Description of PR

Cisco-8000 platforms added support to display the PSU led colors. This has caused test failures since scripts are hard-coded to expect 'N/A' as the led color for these platforms.

Summary:

Fixes 8/1 PSU related failures from https://migsonic.atlassian.net/browse/MIGSMSFT-246

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

PSU tests cases fail due to expecting N/A PSU led state, when actual colors are now displayed.

How did you do it?

Remove the cisco-8000 led color filter from psu test scripts in order for tests to pass using the default logic.

@spilkey-cisco spilkey-cisco requested a review from prgeor as a code owner August 3, 2023 21:56
@kevinskwang
Copy link
Contributor

@spilkey-cisco can you check if 8101/8102 are both ok with this change on 202205?

@spilkey-cisco
Copy link
Contributor Author

@spilkey-cisco can you check if 8101/8102 are both ok with this change on 202205?

They're all giving expected values for PSU LEDs:

cisco@sonic:~$ show ver | grep Platform:
Platform: x86_64-8101_32h_o-r0
cisco@sonic:~$ show plat psu
PSU    Model         Serial         HW Rev    Voltage (V)    Current (A)    Power (W)  Status    LED
-----  ------------  -----------  --------  -------------  -------------  -----------  --------  -----
PSU 1  PSU650W-ACPE  LIT25022747      0.00          12.00           4.34        52.00  OK        green
PSU 2  PSU650W-ACPE  LIT2502274Z      0.00          12.00           3.94        48.00  OK        green
cisco@sonic:~$ show ver | grep Platform:
Platform: x86_64-8102_64h_o-r0
cisco@sonic:~$ show plat psu
PSU    Model         Serial         HW Rev    Voltage (V)    Current (A)    Power (W)  Status    LED
-----  ------------  -----------  --------  -------------  -------------  -----------  --------  -----
PSU 1  PSU650W-ACPI  LIT24472LMS      0.00          12.11           8.73       105.00  OK        green
PSU 2  PSU650W-ACPI  LIT24472LLR      0.00          12.08           8.70       104.00  OK        green
cisco@sonic:~$ show ver | grep Platform:
Platform: x86_64-8101_32fh_o-r0
cisco@sonic:~$ show plat psu
PSU    Model        Serial         HW Rev    Voltage (V)    Current (A)    Power (W)  Status    LED
-----  -----------  -----------  --------  -------------  -------------  -----------  --------  -----
PSU 1  PSU2KW-ACPI  POG2523K00D      0.00          12.06          13.28       160.00  OK        green
PSU 2  PSU2KW-ACPI  POG2523K02W      0.00          12.06           9.61       115.88  OK        green

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #9993

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #9994

kevinskwang added a commit that referenced this pull request Sep 28, 2023
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 9, 2023
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 9, 2023
mssonicbld pushed a commit that referenced this pull request Oct 9, 2023
mssonicbld pushed a commit that referenced this pull request Oct 9, 2023
kevinskwang added a commit that referenced this pull request Oct 16, 2023
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 17, 2023
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 17, 2023
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants