Cisco-8000 psu led support#9264
Merged
kevinskwang merged 1 commit intosonic-net:masterfrom Aug 28, 2023
Merged
Conversation
prgeor
approved these changes
Aug 15, 2023
Contributor
|
@spilkey-cisco can you check if 8101/8102 are both ok with this change on 202205? |
Contributor
Author
They're all giving expected values for PSU LEDs: |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 15, 2023
Collaborator
|
Cherry-pick PR to 202205: #9993 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 15, 2023
6 tasks
Collaborator
|
Cherry-pick PR to 202305: #9994 |
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 15, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Sep 15, 2023
kevinskwang
added a commit
that referenced
this pull request
Sep 27, 2023
This reverts commit d4c087d.
kevinskwang
added a commit
that referenced
this pull request
Sep 28, 2023
This was referenced Oct 9, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Oct 9, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Oct 9, 2023
kevinskwang
added a commit
that referenced
this pull request
Oct 16, 2023
kevinskwang
added a commit
that referenced
this pull request
Oct 16, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 17, 2023
…onic-net#10158)" (sonic-net#10352) This reverts commit 0dec1a3.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 17, 2023
…onic-net#10158)" (sonic-net#10352) This reverts commit 0dec1a3.
mssonicbld
pushed a commit
that referenced
this pull request
Oct 17, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Oct 17, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Cisco-8000 platforms added support to display the PSU led colors. This has caused test failures since scripts are hard-coded to expect 'N/A' as the led color for these platforms.
Summary:
Fixes 8/1 PSU related failures from https://migsonic.atlassian.net/browse/MIGSMSFT-246
Type of change
Back port request
Approach
What is the motivation for this PR?
PSU tests cases fail due to expecting
N/APSU led state, when actual colors are now displayed.How did you do it?
Remove the
cisco-8000led color filter from psu test scripts in order for tests to pass using the default logic.