[Mellanox] Update tests related to thermal control#9251
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Aug 27, 2023
Merged
[Mellanox] Update tests related to thermal control#9251liat-grozovik merged 1 commit intosonic-net:masterfrom
liat-grozovik merged 1 commit intosonic-net:masterfrom
Conversation
Junchao-Mellanox
approved these changes
Aug 3, 2023
nhe-NV
approved these changes
Aug 4, 2023
liat-grozovik
approved these changes
Aug 27, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 28, 2023
Update tests related to thermal control due to the thermal control mechanism being changed for Nvidia device. Update test_get_fans_target_speed, test_show_platform_fanstatus_mocked and test_show_platform_temperature_mocked Remove tests/platform_tests/mellanox/test_thermal_control.py due to the case is not suitable for the new thermal control mechanism - What is the motivation for this PR? Update tests related to thermal control due to the thermal control mechanism being changed. - How did you do it? Update tests related to thermal control - How did you verify/test it? run tests related to thermal control on the image supporting new thermal control mechanism
Collaborator
|
Cherry-pick PR to 202305: #9667 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2023
Update tests related to thermal control due to the thermal control mechanism being changed for Nvidia device. Update test_get_fans_target_speed, test_show_platform_fanstatus_mocked and test_show_platform_temperature_mocked Remove tests/platform_tests/mellanox/test_thermal_control.py due to the case is not suitable for the new thermal control mechanism - What is the motivation for this PR? Update tests related to thermal control due to the thermal control mechanism being changed. - How did you do it? Update tests related to thermal control - How did you verify/test it? run tests related to thermal control on the image supporting new thermal control mechanism
Collaborator
|
@JibinBao I saw below error on my testbed. Looks like the function |
Contributor
Author
|
@bingwang-ms Because this function is in the PR https://github.com/sonic-net/sonic-mgmt/pull/8712,but it is still under review. |
Collaborator
Thanks! The PR #9942 is merged |
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Update tests related to thermal control due to the thermal control mechanism being changed for Nvidia device. Update test_get_fans_target_speed, test_show_platform_fanstatus_mocked and test_show_platform_temperature_mocked Remove tests/platform_tests/mellanox/test_thermal_control.py due to the case is not suitable for the new thermal control mechanism - What is the motivation for this PR? Update tests related to thermal control due to the thermal control mechanism being changed. - How did you do it? Update tests related to thermal control - How did you verify/test it? run tests related to thermal control on the image supporting new thermal control mechanism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Update tests related to thermal control due to the thermal control mechanism being changed for Nvidia device.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Update tests related to thermal control due to the thermal control mechanism being changed.
How did you do it?
Update tests related to thermal control
How did you verify/test it?
run tests related to thermal control on the image supporting new thermal control mechanism
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Any
Documentation