[dualtor] Disable running icmp_responder at session-level#9117
Merged
lolyu merged 1 commit intosonic-net:masterfrom Jul 26, 2023
Merged
[dualtor] Disable running icmp_responder at session-level#9117lolyu merged 1 commit intosonic-net:masterfrom
icmp_responder at session-level#9117lolyu merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
lipxu
approved these changes
Jul 26, 2023
Collaborator
|
Cherry-pick PR to 202205: #9120 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 26, 2023
…t#9117) Approach What is the motivation for this PR? Disable running icmp_responder at session level. The reason is that enabling icmp_responder at the session level could cause some T0 testcase failures as the ICMP replies pollute the FDB table. For example: Port Ethernet4, mux server IP 192.168.0.2, connected to ptf port eth1 that has mac A. Port Ethernet40, connected to ptf port eth10 that has mac B. Some T0 testcases configure 192.168.0.2 IP on ptf port eth10, DUTs will learn the arp as 192.168.0.2 with mac B on port Ethernet40. After linkmgrd learns the arp, it will send heartbeats to 192.168.0.2 with dest mac as B on Ethernet4. As the icmp_responder is running, DUT will receive heartbeat replies with source IP 192.168.0.2 and source mac B on Ethernet4. So DUT will learn mac B on Ethernet4, the arp entry of 192.168.0.2 will be: mac B on port Ethernet40. In this case, the following I/O verification will fail. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? How did you verify/test it?
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 26, 2023
Approach What is the motivation for this PR? Disable running icmp_responder at session level. The reason is that enabling icmp_responder at the session level could cause some T0 testcase failures as the ICMP replies pollute the FDB table. For example: Port Ethernet4, mux server IP 192.168.0.2, connected to ptf port eth1 that has mac A. Port Ethernet40, connected to ptf port eth10 that has mac B. Some T0 testcases configure 192.168.0.2 IP on ptf port eth10, DUTs will learn the arp as 192.168.0.2 with mac B on port Ethernet40. After linkmgrd learns the arp, it will send heartbeats to 192.168.0.2 with dest mac as B on Ethernet4. As the icmp_responder is running, DUT will receive heartbeat replies with source IP 192.168.0.2 and source mac B on Ethernet4. So DUT will learn mac B on Ethernet4, the arp entry of 192.168.0.2 will be: mac B on port Ethernet40. In this case, the following I/O verification will fail. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? How did you verify/test it?
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…t#9117) Approach What is the motivation for this PR? Disable running icmp_responder at session level. The reason is that enabling icmp_responder at the session level could cause some T0 testcase failures as the ICMP replies pollute the FDB table. For example: Port Ethernet4, mux server IP 192.168.0.2, connected to ptf port eth1 that has mac A. Port Ethernet40, connected to ptf port eth10 that has mac B. Some T0 testcases configure 192.168.0.2 IP on ptf port eth10, DUTs will learn the arp as 192.168.0.2 with mac B on port Ethernet40. After linkmgrd learns the arp, it will send heartbeats to 192.168.0.2 with dest mac as B on Ethernet4. As the icmp_responder is running, DUT will receive heartbeat replies with source IP 192.168.0.2 and source mac B on Ethernet4. So DUT will learn mac B on Ethernet4, the arp entry of 192.168.0.2 will be: mac B on port Ethernet40. In this case, the following I/O verification will fail. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? How did you verify/test it?
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Disable running
icmp_responderat session level.The reason is that enabling
icmp_responderat the session level could cause some T0 testcase failures as the ICMP replies pollute the FDB table.For example:
Port
Ethernet4, mux server IP192.168.0.2, connected to ptf porteth1that has macA.Port
Ethernet40, connected to ptf porteth10that has macB.Some T0 testcases configure
192.168.0.2IP on ptf porteth10, DUTs will learn the arp as192.168.0.2with macBon portEthernet40. After linkmgrd learns the arp, it will send heartbeats to192.168.0.2with dest mac asBonEthernet4. As theicmp_responderis running, DUT will receive heartbeat replies with source IP192.168.0.2and source macBonEthernet4.So DUT will learn mac
BonEthernet4, the arp entry of192.168.0.2will be: macBon portEthernet40.In this case, the following I/O verification will fail.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation