Skip to content

[advanced-reboot] Handle logs on tmpfs for all new platforms#9094

Merged
vaibhavhd merged 1 commit intosonic-net:masterfrom
vaibhavhd:logs_on_tmpfs
Jul 27, 2023
Merged

[advanced-reboot] Handle logs on tmpfs for all new platforms#9094
vaibhavhd merged 1 commit intosonic-net:masterfrom
vaibhavhd:logs_on_tmpfs

Conversation

@vaibhavhd
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Tests failing on newly addded platforms where logs are moved to tmpfs.

Related PR: sonic-net/sonic-buildimage#15077

Fixes: sonic-net/sonic-buildimage#15895
This change updates the check from hwsku match to platform match

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@vaibhavhd vaibhavhd requested a review from prgeor as a code owner July 24, 2023 06:19
@bingwang-ms
Copy link
Collaborator

The change looks good to me.
I'm thinking why do we need to check the SKU? Can we just check the log.tmpfs path and handle the logs in the directory if any log file is present?

@vaibhavhd
Copy link
Contributor Author

ests failing on newly addded platforms where logs are moved to tmpfs.

Related PR: sonic-net/sonic-buildimage#15077

Fixes: sonic-net/sonic-buildimage#15895 This change updates the check from hwsku match to platform match

There is an OR check for logs on tmpfs.

The check for platform is needed when base image does not have logs on tmpfs (eg., 201911), and target does (202205).
In that case when test starts the logs are on disk.

@mssonicbld
Copy link
Collaborator

@vaibhavhd PR conflicts with 202205 branch

@mssonicbld
Copy link
Collaborator

@vaibhavhd PR conflicts with 202012 branch

AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
…et#9094)

Fix the tests failing on newly addded platforms where logs are moved to tmpfs.

Related PR: sonic-net/sonic-buildimage#15077

Fixes: sonic-net/sonic-buildimage#15895
This change updates the check from hwsku match to platform match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[202205][syslog]: Log files are disappeared(cleaned) after reboot

4 participants