Revert "[dualtor] Leave icmp_responder running on dualtor topology"#9084
Closed
Revert "[dualtor] Leave icmp_responder running on dualtor topology"#9084
icmp_responder running on dualtor topology"#9084Conversation
Contributor
Contributor
|
Created internal bug item#24616436 to track. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8909
The rationale of this reversion:
It appeared that leaving
icmp_responderrunning will have unexpected dataplane impact:garp_servicerunning, the icmp probe replies will pollute the fdb table, those tests that assigns Vlan subnet address to ptf port will be not able to verify the traffic forwarding as the fdb mapping is not correct.garp_servicerunning,linkmgrdwill send heartbeats with dest mac as zero mac, and the probe replies that has zero mac as src mac will be dropped by the root fanout.So let's revert it for now, and add it back when we have better solutions for the above two impacts.