[Mellanox][DualTor] Skip dualtor ecn test cases for inner dscp 2 and 6 on Nvidia platforms.#9001
Merged
ZhaohuiS merged 1 commit intosonic-net:masterfrom Sep 27, 2023
Merged
Conversation
In the dualtor scenario, when dscp remapping is enabled and packet with dscp 2 or 6 is received by the standby tor, the mapping behavior is different between Nvidia and other vendors, so the test cases fail on Nvidia platforms. Actually, this is not considered as a valid use case, the dscp 2 and 6 should be reserved for the remapped packets. And this has been confirmed with MSFT, so skip the cases for dscp 2 and 6 on Nvidia platforms when dscp remapping is enabled. Change-Id: Icdf19a7191d25c36bdd4cdc659e96297f924abf7
congh-nvidia
changed the title
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nhe-NV
approved these changes
Aug 24, 2023
Collaborator
|
@stephenxs please review as well |
liat-grozovik
changed the title
Collaborator
|
@bingwang-ms FYI |
stephenxs
approved these changes
Aug 29, 2023
bingwang-ms
approved these changes
Sep 26, 2023
Collaborator
|
LGTM. @ZhaohuiS Can you please also help review? Thanks |
ZhaohuiS
approved these changes
Sep 27, 2023
Collaborator
|
@congh-nvidia PR conflicts with 202205 branch |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 27, 2023
In the dualtor scenario, when dscp remapping is enabled and packet with dscp 2 or 6 is received by the standby tor, the mapping behavior is different between Nvidia and other vendors, so the test cases fail on Nvidia platforms. Actually, this is not considered as a valid use case, the dscp 2 and 6 should be reserved for the remapped packets. And this has been confirmed with MSFT, so skip the cases for dscp 2 and 6 on Nvidia platforms when dscp remapping is enabled. Change-Id: Icdf19a7191d25c36bdd4cdc659e96297f924abf7
Collaborator
|
Cherry-pick PR to 202305: #10151 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 27, 2023
In the dualtor scenario, when dscp remapping is enabled and packet with dscp 2 or 6 is received by the standby tor, the mapping behavior is different between Nvidia and other vendors, so the test cases fail on Nvidia platforms. Actually, this is not considered as a valid use case, the dscp 2 and 6 should be reserved for the remapped packets. And this has been confirmed with MSFT, so skip the cases for dscp 2 and 6 on Nvidia platforms when dscp remapping is enabled. Change-Id: Icdf19a7191d25c36bdd4cdc659e96297f924abf7
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
In the dualtor scenario, when dscp remapping is enabled and packet with dscp 2 or 6 is received by the standby tor, the mapping behavior is different between Nvidia and other vendors, so the test cases fail on Nvidia platforms. Actually, this is not considered as a valid use case, the dscp 2 and 6 should be reserved for the remapped packets. And this has been confirmed with MSFT, so skip the cases for dscp 2 and 6 on Nvidia platforms when dscp remapping is enabled. Change-Id: Icdf19a7191d25c36bdd4cdc659e96297f924abf7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
In the dualtor scenario, when dscp remapping is enabled and packet with dscp 2 or 6 is received by the standby tor, the mapping behavior is different between Nvidia and other vendors.
On Nvidia platforms, the downstream packet with dscp 2 or 6 on the standby tor will be encapsulated with the same 2 or 6 outer dscp and bounced back to the tunnel as lossless packet. And this behavior will cause the dualtor ecn test fail.
Actually, this is not considered as a valid use case, the dscp 2 and 6 should be reserved for the remapped tunnel traffic. And this has been discussed and confirmed with the Community.
So, we need to skip the cases for dscp 2 and 6 on Nvidia platforms when dscp remapping is enabled.
Type of change
Back port request
Approach
What is the motivation for this PR?
Skip the dualtor ecn test cases for dscp 2 and 6 on Nvidia platforms when dscp remapping is enabled.
How did you do it?
Add the skip logic in the test cases.
How did you verify/test it?
By running the test on Nvidia 4600c dualtor testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation