Skip to content

Fix python crash in case data plane never stop on fast-reboot #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavel-shirshov merged 5 commits into from
Jun 8, 2019
Merged

Fix python crash in case data plane never stop on fast-reboot #893

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44a781a
Do not crash in case data plane never stop on fast-reboot; Insert 1ms…
Apr 26, 2019
f8c8e03
Fix review comments
May 7, 2019
434154a
Fix review comments
May 7, 2019
5650d2e
Message format
May 8, 2019
721d469
Remove interpacket gap
May 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ansible/roles/test/files/ptftests/advanced-reboot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,8 @@ def runTest(self):
no_routing_start = None
no_routing_stop = None
no_cp_replies = None
upper_replies = []
routing_always = False

arista_vms = self.test_params['arista_vms'][1:-1].split(",")
ssh_targets = []
Expand Down Expand Up @@ -590,14 +592,16 @@ def runTest(self):
self.log("Data plane was stopped, Waiting until it's up. Stop time: %s" % str(no_routing_start))
except TimeoutError:
self.log("Data plane never stop")
no_routing_start = datetime.datetime.min
routing_always = True
upper_replies = [self.nr_vl_pkts]

if no_routing_start is not None:
self.timeout(self.task_timeout, "DUT hasn't started to work for %d seconds" % self.task_timeout)
no_routing_stop, _ = self.check_forwarding_resume()
self.cancel_timeout()
else:
no_routing_stop = datetime.datetime.min
no_routing_start = datetime.datetime.min

# Stop watching DUT
self.watching = False
Expand Down Expand Up @@ -690,7 +694,8 @@ def runTest(self):

if no_routing_stop:
self.log("Downtime was %s" % str(no_routing_stop - no_routing_start))
self.log("Reboot time was %s" % str(no_routing_stop - self.reboot_start))
reboot_time = "0:00:00" if routing_always else str(no_routing_stop - self.reboot_start)
self.log("Reboot time was %s" % reboot_time)
self.log("Expected downtime is less then %s" % self.limit)

if self.reboot_type == 'fast-reboot' and no_cp_replies:
Expand Down