Skip to content

[dualtor] Leave icmp_responder running on dualtor topology #8909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zjswhhh merged 2 commits into from
Jul 17, 2023
Merged

[dualtor] Leave icmp_responder running on dualtor topology #8909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bea560a
leave icmp_responder running
zjswhhh Jul 11, 2023
64fd71a
add log
zjswhhh Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions tests/common/fixtures/ptfhost_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,17 +269,8 @@ def run_icmp_responder_session(duthosts, duthost, ptfhost, tbinfo):

yield

if "dualtor-mixed" in tbinfo["topo"]["name"] or "dualtor-aa" in tbinfo["topo"]["name"]:
logger.info("Leave icmp_responder running for dualtor-mixed/dualtor-aa topology")
return

logger.info("Stop running icmp_responder")
ptfhost.shell("supervisorctl stop icmp_responder")
icmp_responder_session_started = False

logger.info("Recover linkmgrd probe interval")
recover_linkmgrd_probe_interval(duthosts, tbinfo)
duthosts.shell("config save -y")
logger.info("Leave icmp_responder running for dualtor/dualtor-mixed/dualtor-aa topology")
return


@pytest.fixture(scope="module", autouse=True)
Expand Down