[202012]Set key "asic0" in single-asic scenerio to keep consistent with multi-asic in function core_dump_and_config_check.#8886
Merged
wangxin merged 1 commit intosonic-net:202012from Jul 10, 2023
Conversation
Collaborator
|
@yutongzhang-microsoft How did you verify/test it? |
Contributor
Author
I tested using 202012 branch, and no error occurs. |
wangxin
approved these changes
Jul 10, 2023
Merged
6 tasks
yutongzhang-microsoft
added a commit
that referenced
this pull request
Jul 14, 2023
…heck` in 202012 branch. (#8980) Description of PR In 202012 branch, there is no multi-asic scenerio. But in PR (#8886) and (#8880), they innovate multi-asic scenerio in fixture core_dump_and_config_check. We think this innovation is unnecessary, so in this PR, we delete the code related to multi-asic scenerio. What is the motivation for this PR? In 202012 branch, there is no multi-asic scenerio. But in PR (#8886) and (#8880), they innovate multi-asic scenerio in fixture core_dump_and_config_check. We think this innovation is unnecessary, so in this PR, we delete the code related to multi-asic scenerio. How did you do it? Remove the code related to multi-asic scenerio in fixture core_dump_and_config_check. Signed-off-by: Yutong Zhang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
There is a cherry pick conflict in 202012 branch of PR (#8884).
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
There is a cherry pick conflict in 202012 branch of PR (#8884).
How did you do it?
How did you verify/test it?
I tested using 202012 branch on 202012 image, and no error occurs.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation