[IPv6][SNMP]: Remove skip of IPv6 loopback testing#8824
Merged
SuvarnaMeenakshi merged 4 commits intosonic-net:masterfrom Jul 26, 2023
Merged
[IPv6][SNMP]: Remove skip of IPv6 loopback testing#8824SuvarnaMeenakshi merged 4 commits intosonic-net:masterfrom
SuvarnaMeenakshi merged 4 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Contributor
Do you want to remove this TODO? In reply to: 1622614016 Refers to: tests/snmp/test_snmp_loopback.py:56 in 384205c. [](commit_id = 384205c, deletion_comment = False) |
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Contributor
Author
Removed comment. This test specifically tests over loopback IPv4 and IPv6. |
qiluo-msft
previously approved these changes
Jul 5, 2023
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Contributor
Author
|
@qiluo-msft can you review this. |
qiluo-msft
approved these changes
Jul 26, 2023
Collaborator
|
@SuvarnaMeenakshi PR conflicts with 202205 branch |
SuvarnaMeenakshi
added a commit
to SuvarnaMeenakshi/sonic-mgmt
that referenced
this pull request
Sep 14, 2023
What is the motivation for this PR? SNMP over Loopback ipv6 is currently being skipped. sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6. After the above fix, SNMP over Loopback and management should work. How did you do it? Remove skip of ipv6. How did you verify/test it? Test on vs testbed with single-asic image with sonic-buildimage 15487 fix. Prerequisite PRs: sonic-net/sonic-buildimage#15688 sonic-net/sonic-buildimage#15487 (cherry picked from commit bcf44a1)
6 tasks
wangxin
pushed a commit
that referenced
this pull request
Sep 15, 2023
Cherry-pick with conflict resolution of #8824 What is the motivation for this PR? SNMP over Loopback ipv6 is currently being skipped. sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6. After the above fix, SNMP over Loopback and management should work. How did you do it? Remove skip of ipv6. How did you verify/test it? Test on vs testbed with single-asic image with sonic-buildimage 15487 fix. Prerequisite PRs: sonic-net/sonic-buildimage#15688 sonic-net/sonic-buildimage#15487 (cherry picked from commit bcf44a1)
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? SNMP over Loopback ipv6 is currently being skipped. sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6. After the above fix, SNMP over Loopback and management should work. How did you do it? Remove skip of ipv6. How did you verify/test it? Test on vs testbed with single-asic image with sonic-buildimage 15487 fix. Prerequisite PRs: sonic-net/sonic-buildimage#15688 sonic-net/sonic-buildimage#15487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.
How did you do it?
Remove skip of ipv6.
How did you verify/test it?
Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.
Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation