[fast/warm reboot] improve new image installation code#877
Merged
yxieca merged 5 commits intosonic-net:masterfrom Apr 18, 2019
Merged
[fast/warm reboot] improve new image installation code#877yxieca merged 5 commits intosonic-net:masterfrom
yxieca merged 5 commits intosonic-net:masterfrom
Conversation
- Allow new_sonic_image being defined as empty string. It causes skipping image installation. - Rename new_image_location to a generic name. - Display defined new image url. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
qiluo-msft
reviewed
Apr 17, 2019
qiluo-msft
reviewed
Apr 17, 2019
…elease This feature is needed in order to test ugprade path. Where we might upgrade from one version to another, and more. We want the system to stay in target release for next steps. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
qiluo-msft
reviewed
Apr 17, 2019
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
…/fast reboot When new image is specified for fast/warm reboot. The new image will be installed. However, if the specified image is already installed on the target DUT, then sonic_install will fail and fast/warm reboot will reboot into current image. Add a knob to cleanup old images so that the installing of new image will have a better chance to succeed. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
qiluo-msft
reviewed
Apr 18, 2019
qiluo-msft
reviewed
Apr 18, 2019
| - name: Cleanup sonic images that is not current and/or next | ||
| shell: sonic_installer cleanup -y | ||
| become: true | ||
| when: cleanup_old_sonic_images|bool |
Contributor
There was a problem hiding this comment.
|bool [](start = 40, length = 5)
not needed. #Closed
Collaborator
Author
There was a problem hiding this comment.
Same reason as above. It is needed.
qiluo-msft
reviewed
Apr 18, 2019
qiluo-msft
reviewed
Apr 18, 2019
qiluo-msft
approved these changes
Apr 18, 2019
yxieca
added a commit
that referenced
this pull request
Apr 18, 2019
* [fast/warm reboot] improve new image installation code - Allow new_sonic_image being defined as empty string. It causes skipping image installation. - Rename new_image_location to a generic name. - Display defined new image url. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [fast/warm reboot] allow DUT to stay in the warm/fast reboot target release This feature is needed in order to test ugprade path. Where we might upgrade from one version to another, and more. We want the system to stay in target release for next steps. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Address review comments, test issues and some minor touch-ups Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [fast/warm reboot] add knob to clean up old iamges on DUT before warm/fast reboot When new image is specified for fast/warm reboot. The new image will be installed. However, if the specified image is already installed on the target DUT, then sonic_install will fail and fast/warm reboot will reboot into current image. Add a knob to cleanup old images so that the installing of new image will have a better chance to succeed. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * address review issue
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
…X6-64PE-B-P32O64 (sonic-net#877) Cherry-pick sonic-net#21323 into msft-202503 <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Add T0/T1 topo files for hwsku Arista-7060X6-64PE-B-P32V128 and Arista-7060X6-64PE-B-P32O64 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Add topo for F2 storage cluster #### How did you do it? updated generate_topo.py and added relevant files. #### How did you verify/test it? on local testbed #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Signed-off-by: Ying Xie ying.xie@microsoft.com
How did you verify/test it?