[minigraph] Fix minigraph parsing error on Mellanox-SN2700-D48C8#875
Merged
lguohan merged 1 commit intosonic-net:masterfrom Apr 17, 2019
Merged
[minigraph] Fix minigraph parsing error on Mellanox-SN2700-D48C8#875lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
jleveque
approved these changes
Apr 17, 2019
lguohan
approved these changes
Apr 17, 2019
qiluo-msft
added a commit
that referenced
this pull request
Apr 17, 2019
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
yxieca
added a commit
that referenced
this pull request
Apr 18, 2019
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-mgmt
that referenced
this pull request
Jun 14, 2019
…8C8 (sonic-net#875)" into develop
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This PR is to enable retry for some EOS command. Retry is enabled for below functions for now as we saw connection error frequently on these commands, and the failure will leave testbed in unhealthy state. - no_shutdown - shutdown - start_bgpd - no_shutdown_bgp - no_shutdown_bgp_neighbors ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202503 ### Approach #### What is the motivation for this PR? This PR is to enable retry for some EOS command. #### How did you do it? Leverage Python module `retry` to rerun the command if there is exception. #### How did you verify/test it? The change is verified by running on a physical testbed. Retry is working if connection issue happened. ``` 22:18:47 api.__retry_internal L0040 WARNING| run module eos_config failed, Ansible Results => failed = True module_stdout = module_stderr = command timeout triggered, timeout value is 60 secs. See the timeout setting options in the Network Debug and Troubleshooting Guide. msg = MODULE FAILURE See stdout/stderr for the exact error _ansible_no_log = None changed = False stdout = stderr = , retrying in 5 seconds... 22:19:53 api.__retry_internal L0040 WARNING| run module eos_config failed, Ansible Results => failed = True module_stdout = module_stderr = command timeout triggered, timeout value is 60 secs. See the timeout setting options in the Network Debug and Troubleshooting Guide. msg = MODULE FAILURE See stdout/stderr for the exact error _ansible_no_log = None changed = False stdout = stderr = , retrying in 5 seconds... 22:20:58 __init__.pytest_runtest_call L0040 ERROR | Traceback (most recent call last): ``` #### Any platform specific information? No. #### Supported testbed topology if it's a new test case? Not a new test. ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug introduced by #674