[pfcwd] Add testcase for pfcwd multi port storm trigger and restore#8709
Merged
neethajohn merged 1 commit intosonic-net:masterfrom Jun 26, 2023
Merged
[pfcwd] Add testcase for pfcwd multi port storm trigger and restore#8709neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Neetha John <nejo@microsoft.com>
lipxu
approved these changes
Jun 26, 2023
Contributor
|
Hi, @neethajohn , seems this case is for triggering of PFCWD behavior on multiple ports sequentially, Is there any difference in behavior between triggering PFCWD on multiple ports simultaneously? |
Contributor
Author
Yes, there was some issues seen in some platforms when wd was triggered sequentially but could not see any issues when wd was triggered simulataneously on multiple ports, hence this testcase |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 11, 2023
neethajohn
added a commit
to neethajohn/sonic-mgmt
that referenced
this pull request
Sep 20, 2023
Backport sonic-net#8709 Signed-off-by: Neetha John <nejo@microsoft.com>
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
…onic-net#8709) Signed-off-by: Neetha John <nejo@microsoft.com> What is the motivation for this PR? Add a testcase to test pfcwd detection/restoration/action when 2 ports are in storm one after the other How did you verify/test it? Ran the entire pfcwd functionality suite against brcm and mlnx platforms and they passed collected 4 items pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_actions[str2-dx010-acs-7-None] PASSED [ 25%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_multi_port[str2-dx010-acs-7-None] PASSED [ 50%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_mmu_change[str2-dx010-acs-7-None] PASSED [ 75%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_port_toggle[str2-dx010-acs-7-None] PASSED [100%] -------------------------------------------------------------------------------------------- generated xml file: /var/nejo/tests/logs/tr.xml --------------------------------------------------------------------------------------------================================================================================================ 4 passed, 1 warnings in 2049.92 seconds ================================================================================================ collected 4 items pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_actions[str-msn2700-22-None] PASSED [ 25%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_multi_port[str-msn2700-22-None] PASSED [ 50%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_mmu_change[str-msn2700-22-None] PASSED [ 75%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_port_toggle[str-msn2700-22-None] PASSED [100%] -------------------------------------------------------------------------------------------- generated xml file: /var/nejo/tests/logs/tr.xml -------------------------------------------------------------------------------------------- ================================================================================================ 4 passed, 1 warnings in 2171.81 seconds ================================================================================================
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…onic-net#8709) Signed-off-by: Neetha John <nejo@microsoft.com> What is the motivation for this PR? Add a testcase to test pfcwd detection/restoration/action when 2 ports are in storm one after the other How did you verify/test it? Ran the entire pfcwd functionality suite against brcm and mlnx platforms and they passed collected 4 items pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_actions[str2-dx010-acs-7-None] PASSED [ 25%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_multi_port[str2-dx010-acs-7-None] PASSED [ 50%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_mmu_change[str2-dx010-acs-7-None] PASSED [ 75%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_port_toggle[str2-dx010-acs-7-None] PASSED [100%] -------------------------------------------------------------------------------------------- generated xml file: /var/nejo/tests/logs/tr.xml --------------------------------------------------------------------------------------------================================================================================================ 4 passed, 1 warnings in 2049.92 seconds ================================================================================================ collected 4 items pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_actions[str-msn2700-22-None] PASSED [ 25%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_multi_port[str-msn2700-22-None] PASSED [ 50%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_mmu_change[str-msn2700-22-None] PASSED [ 75%] pfcwd/test_pfcwd_function.py::TestPfcwdFunc::test_pfcwd_port_toggle[str-msn2700-22-None] PASSED [100%] -------------------------------------------------------------------------------------------- generated xml file: /var/nejo/tests/logs/tr.xml -------------------------------------------------------------------------------------------- ================================================================================================ 4 passed, 1 warnings in 2171.81 seconds ================================================================================================
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #5239
Type of change
Back port request
Approach
What is the motivation for this PR?
Add a testcase to test pfcwd detection/restoration/action when 2 ports are in storm one after the other
How did you verify/test it?
Ran the entire pfcwd functionality suite against brcm and mlnx platforms and they passed