Skip to content

[ntpd] Update matching pattern of 'ERR ntpd' in loganalyzer ignore files#865

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
wangxin:ntpd-err
Apr 24, 2019
Merged

[ntpd] Update matching pattern of 'ERR ntpd' in loganalyzer ignore files#865
liat-grozovik merged 1 commit intosonic-net:masterfrom
wangxin:ntpd-err

Conversation

@wangxin
Copy link
Collaborator

@wangxin wangxin commented Apr 10, 2019

Description of PR

Summary:
Fixes # (issue)
The ntpd may generate 'ERR ntpd' in syslog and caused unnecessary test
case failure. Previous PR #816
added a matching pattern of 'ERR ntpd' in loganalyzer igonre files to
ignore the ntpd error messages. However, ntpd may generate two formats
of error messages. The previously added matching pattern can only match
one of the formats. This change is to update the pattern to match both
of the formats.

Two formats of ntpd error message observed in testing:

Feb 26 20:23:29.807385 mtbc-sonic-03-2700 ERR ntpd[3816]: routing socket reports: No buffer space available
Apr 9 19:58:02.909960 mtbc-sonic-01-2410 ERR ntpd[12573]: message repeated 6 times: [ routing socket reports: No buffer space available]

Type of change

  • Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

Updated the matching pattern to match two formats of ntpd error messages.

How did you verify/test it?

Verified through python interactive shell.

>>> msg1 = "Feb 26 20:23:29.807385 mtbc-sonic-03-2700 ERR ntpd[3816]: routing socket reports: No buffer space available"
>>> msg2 = "Apr  9 19:58:02.909960 mtbc-sonic-01-2410 ERR ntpd[12573]: message repeated 6 times: [ routing socket reports: No buffer space available]"
>>> import re   
>>> pattern = re.compile(r".* ERR ntpd.*routing socket reports: No buffer space available.*")
>>> pattern.match(msg1)
<_sre.SRE_Match object at 0x7f35c73d87e8>
>>> pattern.match(msg2)
<_sre.SRE_Match object at 0x7f35c73d8850>

Any platform specific information?

No

Supported testbed topology if it's a new test case?

Documentation

The ntpd may generate 'ERR ntpd' in syslog and caused unnecessary test
case failure. Previous PR #816
added a matching pattern of 'ERR ntpd' in loganalyzer igonre files to
ignore the ntpd error messages. However, ntpd may generate two formats
of error messages. The previously added matching pattern can only match
one of the formats. This change is to update the pattern to match both
of the formats.

Signed-off-by: Xin Wang <[email protected]>
@liat-grozovik liat-grozovik merged commit 17ce050 into sonic-net:master Apr 24, 2019
yxieca pushed a commit that referenced this pull request Apr 26, 2019
…les (#865)

The ntpd may generate 'ERR ntpd' in syslog and caused unnecessary test
case failure. Previous PR #816
added a matching pattern of 'ERR ntpd' in loganalyzer igonre files to
ignore the ntpd error messages. However, ntpd may generate two formats
of error messages. The previously added matching pattern can only match
one of the formats. This change is to update the pattern to match both
of the formats.

Signed-off-by: Xin Wang <[email protected]>
@wangxin wangxin deleted the ntpd-err branch May 24, 2019 03:32
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Added logrotate file for wtmp and btmp to override default conf and set size cap as 100K as done in 
PR: sonic-net#865. For buster this is control by separate file wtmp and btmp.

Signed-off-by: Abhishek Dosi <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Added logrotate file for wtmp and btmp to override default conf and set size cap as 100K as done in 
PR: sonic-net#865. For buster this is control by separate file wtmp and btmp.

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants