Fix the label for cherry-pick in workflow yaml#8511
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jun 7, 2023
Merged
Conversation
The workflow added for auto cherry-pick expects label like `Approved for $branch branch`. For the sonic-mgmt repository, people are used to use label like `Request for $branch branch`. Because of this difference, the cherry-pick actions are not really working. This fix updated the expected labels in workflow yaml to `Request for $branch branch`. Signed-off-by: Xin Wang <[email protected]>
wangxin
added a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Jun 7, 2023
PR sonic-net#8511 updated the cherry-pick workflow to use lable "Request for 20xx branch". However, the workflow condition was not updated accordingly. The workflow actions are still skipped when labels like "Request for 20xx branch" is set. This change updated the trigger condition in the workflow yaml to match labels start with "Request for 20". Signed-off-by: Xin Wang <[email protected]>
6 tasks
wangxin
added a commit
that referenced
this pull request
Jun 8, 2023
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
The workflow added for auto cherry-pick expects label like `Approved for $branch branch`. For the sonic-mgmt repository, people are used to use label like `Request for $branch branch`. Because of this difference, the cherry-pick actions are not really working. This fix updated the expected labels in workflow yaml to `Request for $branch branch`. Signed-off-by: Xin Wang <[email protected]>
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
…" (sonic-net#8517) Reverts sonic-net#8511 Before auto cherry-pick a PR, it is better idea to have approval procedure. Let's follow the same practice of sonic-buildimage repo.
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
The workflow added for auto cherry-pick expects label like `Approved for $branch branch`. For the sonic-mgmt repository, people are used to use label like `Request for $branch branch`. Because of this difference, the cherry-pick actions are not really working. This fix updated the expected labels in workflow yaml to `Request for $branch branch`. Signed-off-by: Xin Wang <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…" (sonic-net#8517) Reverts sonic-net#8511 Before auto cherry-pick a PR, it is better idea to have approval procedure. Let's follow the same practice of sonic-buildimage repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The workflow added for auto cherry-pick expects label like
Approved for $branch branch.For the sonic-mgmt repository, people are used to use label like
Request for $branch branch.Because of this difference, the cherry-pick actions are not really working.
How did you do it?
This fix updated the expected labels in workflow yaml to
Request for $branch branch.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation