[minigraph_facts] Refactor such that port names and aliases are never stored together#832
Merged
lguohan merged 2 commits intosonic-net:masterfrom Apr 5, 2019
jleveque:fix_port_index_map
Merged
[minigraph_facts] Refactor such that port names and aliases are never stored together#832lguohan merged 2 commits intosonic-net:masterfrom jleveque:fix_port_index_map
lguohan merged 2 commits intosonic-net:masterfrom
jleveque:fix_port_index_map
Conversation
wendani
approved these changes
Mar 20, 2019
pavel-shirshov
approved these changes
Mar 20, 2019
Contributor
pavel-shirshov
left a comment
pavel-shirshov
left a comment
There was a problem hiding this comment.
LGTM but wait for other reviewers
yxieca
pushed a commit
that referenced
this pull request
Sep 25, 2019
…r stored together (#832) * [minigraph_facts] Refactor such that port names and aliases are never stored together * Update affected playbooks to reflect the new change
deerao02
pushed a commit
to deerao02/sonic-mgmt
that referenced
this pull request
Dec 18, 2025
…tly test (sonic-net#832) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> It seems that the empty test_sfputil.py is causing an error to be seen while running nightly test. Hence, removing this file since the file was originally added as a placeholder. Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? It seems that the empty test_sfputil.py is causing an error to be seen while running nightly test. Hence, removing this file since the file was originally added as a placeholder. #### How did you do it? Removed test_sfputil.py #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> ADO - 33833045
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Make sure db_migrator is run after all config are loaded during (sonic-net#926) Vnet alias mapping (sonic-net#924) Changes to make lldp show command for multi-npu platforms. (sonic-net#914) [Mellanox] Fix thermal control issue: use natural sort for fan status and thermal status (sonic-net#836) [Mellanox] add document for thermal control related cli (sonic-net#832)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more fundamental way to address the potential problems if port names/aliases happen to overlap mentioned here: Fix port alias mapping in minigraph_facts #830. Port names and aliases should never be combined in the same data structure.
Now, once the minigraph is parsed, the resulting output will refer to all ports by their SONiC port name (portchannel members, VLAN members, etc.).
If a play book needs to map between name/alias, the parser generates
minigraph_port_name_to_alias_mapandminigraph_port_alias_to_name_mapfor this purpose.Also update port name/alias map names to make their purposes more clear.