Revert #8213 "Enhance qos tests to support single-asic, multi-asic, and mul…"#8252
Merged
wsycqyz merged 1 commit intosonic-net:202205from May 10, 2023
Merged
Conversation
…ti-dut testing (sonic-net#8213)" This reverts commit 7120af9.
XuChen-MSFT
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7120af9.
Description of PR
Summary:
Fixes many internal QoS test failures caused by #8213
Such as:
File "/azp/_work/26/s/tests/qos/test_pfc_counters.py", line 96, in run_test
peer_port_name = eos_to_linux_intf(peer_port)
File "/azp/_work/26/s/tests/qos/qos_helpers.py", line 38, in eos_to_linux_intf
elif "Nokia" in hwsku:
TypeError: argument of type 'NoneType' is not iterable
Type of change
Back port request
Approach
What is the motivation for this PR?
Fixes many internal QoS test failures caused by #8213
Such as:
File "/azp/_work/26/s/tests/qos/test_pfc_counters.py", line 96, in run_test
peer_port_name = eos_to_linux_intf(peer_port)
File "/azp/_work/26/s/tests/qos/qos_helpers.py", line 38, in eos_to_linux_intf
elif "Nokia" in hwsku:
TypeError: argument of type 'NoneType' is not iterable
How did you do it?
Revert #8213
How did you verify/test it?
N/A
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation