[arp ping] add VLAN arp ping to warm/fast reboot test#824
Merged
yxieca merged 3 commits intosonic-net:masterfrom Mar 19, 2019
Merged
[arp ping] add VLAN arp ping to warm/fast reboot test#824yxieca merged 3 commits intosonic-net:masterfrom
yxieca merged 3 commits intosonic-net:masterfrom
Conversation
- Check incoming packet type, if it is ARP response, don't reply again. Signed-off-by: Ying Xie <[email protected]>
- Making sure that ARP within vlan continue working during warm reboot Signed-off-by: Ying Xie <[email protected]>
pavel-shirshov
approved these changes
Mar 19, 2019
yxieca
added a commit
that referenced
this pull request
Mar 19, 2019
* [arp_responder] only respond to arp request, ignore arp response - Check incoming packet type, if it is ARP response, don't reply again. Signed-off-by: Ying Xie <[email protected]> * [warm/fast reboot] add vlan arp ping check during warm reboot - Making sure that ARP within vlan continue working during warm reboot Signed-off-by: Ying Xie <[email protected]> * Define and use ARP_OP_REQUEST
deerao02
pushed a commit
to deerao02/sonic-mgmt
that referenced
this pull request
Dec 18, 2025
…-net#824) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Skip for test_orchagent_heartbeat as the restartcheck is a feature used only for warm/fast reboot, which is not supported on 202412 branch. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Skip unsupported test #### How did you do it? Set skip for 202412 release #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The purpose of adding the VLAN APR ping, is to make sure that during warm/fast reboot, the servers on the VLAN can still resolve addresses of each other.
Because currently SONiC default behavior is to trap ARP packets to CPU, ARP requests within VLAN get dropped during warm/fast reboot. As result, the arp_ping is added but not used as success criteria.
This test enables testing the change of SONiC behavior from "trap to cpu" to "copy to cpu".
Type of change
Approach
How did you do it?
How did you verify/test it?
Following is log while testing with a binary with VLAN ARP flooding support. Note that before fast reboot, we received double ping responses, because one ping request went to cpu, one went to VLAN, they both eventually reached the arp_responder and got response. When reboot started, the control plane is down, then there is only 1 response from VLAN flooding.
2019-03-08 04:10:25 : Send 100 Received 100 servers->t1
2019-03-08 04:10:27 : Send 500 Received 500 t1->servers
2019-03-08 04:10:27 : Send 10 Received 10 ping DUT
2019-03-08 04:10:28 : Send 1 Received 2 arp ping
2019-03-08 04:10:29 : Send 100 Received 100 servers->t1
2019-03-08 04:10:31 : Send 500 Received 500 t1->servers
2019-03-08 04:10:31 : Send 10 Received 0 ping DUT
2019-03-08 04:10:31 : Control plane state transition from up to down
2019-03-08 04:10:32 : Dut reboots: reboot start 2019-03-08 04:10:32.439384
2019-03-08 04:10:32 : Check that device is still forwarding data plane traffic
2019-03-08 04:10:32 : Send 1 Received 1 arp ping
2019-03-08 04:10:33 : Send 100 Received 100 servers->t1
2019-03-08 04:10:35 : Send 500 Received 500 t1->servers
2019-03-08 04:10:35 : Send 10 Received 0 ping DUT
2019-03-08 04:10:36 : Send 1 Received 1 arp ping