[vxlan-decap]: Minor fixes and acceleration#819
Closed
stcheng wants to merge 1 commit intosonic-net:masterfrom
Closed
[vxlan-decap]: Minor fixes and acceleration#819stcheng wants to merge 1 commit intosonic-net:masterfrom
stcheng wants to merge 1 commit intosonic-net:masterfrom
Conversation
- Exclude *.*.*.0 and *.*.*.1 IP addresses - Return false immediately after encountering first failure - Return result immediately when expecting only 1 packet Signed-off-by: Shu0T1an ChenG <[email protected]>
| if self.nr == 1: | ||
| rv = rv and verify_packet_any_port(self, exp_packet, pc_ports) | ||
| else: | ||
| rv = rv and self.nr == testutils.count_matched_packets_all_ports(self, exp_packet, pc_ports, timeout=0.1) |
Contributor
There was a problem hiding this comment.
Why do we need this change?
| if self.nr == 1: | ||
| rv = rv and verify_packet_any_port(self, exp_packet, [acc_port]) | ||
| else: | ||
| rv = rv and self.nr == testutils.count_matched_packets(self, exp_packet, acc_port, timeout=0.1) |
Contributor
There was a problem hiding this comment.
Why do we need this change?
| config = {} | ||
| for test in self.tests: | ||
| for port in test['acc_ports']: | ||
| if port == 0 or port == 1: |
Contributor
There was a problem hiding this comment.
why do we skip ports indexes 0 and 1?
deerao02
pushed a commit
to deerao02/sonic-mgmt
that referenced
this pull request
Dec 18, 2025
…net#819) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR Optimize check_interface_status function. Add cache to get_ports_map. Call transceiver presence once for all ports together. <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [X ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? As the number of ports increases, the function slows down and may fail the test because not all interfaces up in time. #### How did you do it? Add cache to get_ports_map. Call transceiver presence once for all ports together. #### How did you verify/test it? measure the new time and rerun the test. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…onic-net#7316) - [pyext] Fix pyext/py2 library (sonic-net#820) - Added --purge of base docker image packages before installing new ones. (sonic-net#819) <--- branch point Signed-off-by: Danny Allen <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-utilities 49ab6b1f8..e9747899a: > [reboot] make sure the reboot happens even if platform reboot failed (sonic-net#819) Signed-off-by: Ying Xie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shu0T1an ChenG [email protected]