TestAclReboot test fix for Nokia-400G-T2 chassis by sanjair-git · Pull Request #8172 · sonic-net/sonic-mgmt

sanjair-git · 2023-04-27T19:33:36Z

Description of PR

Summary:
Fixes # (issue)

TestAclWithReboot ACL test case is not waiting long enough for the interfaces to come up with respect to Nokia IXR7250E-36x400G DUT.
Due to this, ACL tests' call (under TestAclWithReboot) start thinking all interfaces are up and fails.

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911
202012
202205

Approach

What is the motivation for this PR?

This PR helps to fix the TestAclWithReboot ACL test cases w.r.t Nokia IXR7250E-36x400G platform.
Test cases are not waiting long enough for the interfaces to come up with respect to Nokia IXR7250E-36x400G DUT.

How did you do it?

If the platform is 'Nokia IXR7250E-36x400G', wait long enough and make sure all the interfaces and transceivers are UP & running.
Once the ports are up, then proceed with running the ACL test calls.

How did you verify/test it?

Ran all the ACL test cases against a multi-asic line card in a T2 chassis including Nokia IXR7250E-36x400G.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2023-04-27T19:34:34Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/acl/test_acl.py:25:1: F401 'tests.common.fixtures.conn_graph_facts.conn_graph_facts' imported but unused tests/acl/test_acl.py:159:1: E302 expected 2 blank lines, found 1 tests/acl/test_acl.py:238:1: E302 expected 2 blank lines, found 1 tests/acl/test_acl.py:455:1: E302 expected 2 blank lines, found 1 tests/acl/test_acl.py:583:82: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:613:31: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:1176:82: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:1213:82: F811 redefinition of unused 'conn_graph_facts' from line 25

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2023-04-27T19:44:41Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/acl/test_acl.py:25:1: F401 'tests.common.fixtures.conn_graph_facts.conn_graph_facts' imported but unused tests/acl/test_acl.py:586:82: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:616:31: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:1179:82: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:1216:82: F811 redefinition of unused 'conn_graph_facts' from line 25

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2023-04-27T20:35:22Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/acl/test_acl.py:586:82: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:616:31: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:1179:82: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:1216:82: F811 redefinition of unused 'conn_graph_facts' from line 25

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

This reverts commit ec6f765.

mssonicbld · 2023-04-27T20:41:13Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/acl/test_acl.py:25:1: F401 'tests.common.fixtures.conn_graph_facts.conn_graph_facts' imported but unused tests/acl/test_acl.py:586:82: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:616:31: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:1179:82: F811 redefinition of unused 'conn_graph_facts' from line 25 tests/acl/test_acl.py:1216:82: F811 redefinition of unused 'conn_graph_facts' from line 25

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

* TestAclReboot test fix for Nokia-400G-T2 DUT * Indentation changes * Adding #noqa to import warning * Revert "Adding #noqa to import warning" This reverts commit ec6f765. * Precommit error fixes

mssonicbld · 2023-06-29T01:51:02Z

Cherry-pick PR to 202205: #8759

* TestAclReboot test fix for Nokia-400G-T2 DUT * Indentation changes * Adding #noqa to import warning * Revert "Adding #noqa to import warning" This reverts commit ec6f765. * Precommit error fixes

TestAclReboot test fix for Nokia-400G-T2 DUT

13e4383

Indentation changes

72ada19

Adding #noqa to import warning

ec6f765

Revert "Adding #noqa to import warning"

e84f311

This reverts commit ec6f765.

Precommit error fixes

ea29701

rlhui requested a review from tjchadaga June 23, 2023 07:21

tjchadaga approved these changes Jun 24, 2023

View reviewed changes

tjchadaga merged commit 851c21d into sonic-net:master Jun 24, 2023

tjchadaga added the Request for 202205 branch label Jun 24, 2023

wangxin added the Approved for 202205 branch label Jun 29, 2023

mssonicbld added the Created PR to 202205 branch label Jun 29, 2023

mssonicbld mentioned this pull request Jun 29, 2023

[action] [PR:8172] TestAclReboot test fix for Nokia-400G-T2 chassis #8759

Merged

6 tasks

mssonicbld added Included in 202205 branch and removed Created PR to 202205 branch labels Jun 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TestAclReboot test fix for Nokia-400G-T2 chassis#8172

TestAclReboot test fix for Nokia-400G-T2 chassis#8172
tjchadaga merged 5 commits intosonic-net:masterfrom
sanjair-git:acl-reboot-fix

sanjair-git commented Apr 27, 2023

Uh oh!

mssonicbld commented Apr 27, 2023

Uh oh!

mssonicbld commented Apr 27, 2023

Uh oh!

mssonicbld commented Apr 27, 2023

Uh oh!

mssonicbld commented Apr 27, 2023

Uh oh!

mssonicbld commented Jun 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sanjair-git commented Apr 27, 2023

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Apr 27, 2023

Uh oh!

mssonicbld commented Apr 27, 2023

Uh oh!

mssonicbld commented Apr 27, 2023

Uh oh!

mssonicbld commented Apr 27, 2023

Uh oh!

mssonicbld commented Jun 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants