[202205][qos] address qos helper exception when hwsku is None#8148
Merged
yxieca merged 1 commit intosonic-net:202205from Apr 25, 2023
Merged
[202205][qos] address qos helper exception when hwsku is None#8148yxieca merged 1 commit intosonic-net:202205from
yxieca merged 1 commit intosonic-net:202205from
Conversation
Signed-off-by: Ying Xie <[email protected]>
neethajohn
approved these changes
Apr 25, 2023
yxieca
changed the title
vmittal-msft
approved these changes
Apr 25, 2023
wsycqyz
added a commit
to wsycqyz/sonic-mgmt
that referenced
this pull request
Apr 26, 2023
This reverts commit 7d8f8f0.
6 tasks
wsycqyz
added a commit
that referenced
this pull request
Apr 26, 2023
…re (#8154) What is the motivation for this PR? QoS SAI test failed (test setup failed) due to #8059 and #8148 How did you do it? * Revert "[202205][qos] address qos helper issue (#8148)" This reverts commit 7d8f8f0. * Revert "Enhance qos tests to support single-asic, multi-asic, and multi-dut testing (#8059)" This reverts commit b1beed0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This change is to address an issue introduced by PR #8059, where hwsku might be None since caller didn't pass it in. And the check "Nokia" in hwsku causes exception.
How did you do it?
Protect against hwsku is None scenario.
How did you verify/test it?
Manually tested the new code structure when hwsku is none.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation