Skip to content

[warm/fast reboot] fail fast/warm reboot test if BGP GR timeout is detected#805

Merged
yxieca merged 2 commits intomasterfrom
bgp_gr_timeout
Feb 12, 2019
Merged

[warm/fast reboot] fail fast/warm reboot test if BGP GR timeout is detected#805
yxieca merged 2 commits intomasterfrom
bgp_gr_timeout

Conversation

@yxieca
Copy link
Copy Markdown
Collaborator

@yxieca yxieca commented Feb 12, 2019 •
edited
Loading

  • [] Bug fix
  • [] Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

Watch VM log, if BGP graceful restart timeout is detected, fail the test.

How did you verify/test it?

  • warm reboot: pass
  • fast reboot: pass
  • add artificial delay after stopping bgp in warm reboot test: fail as expected:

======================================================================
FAIL: advanced-reboot.ReloadTest

Traceback (most recent call last):
File "ptftests/advanced-reboot.py", line 1003, in runTest
self.assertTrue(is_good, errors)
AssertionError:

Something went wrong. Please check output below:

    "FAILED:10.64.247.203:BGP route GR timeout: neighbor 10.0.0.38 (ASN 4200065100)", 
    "FAILED:10.64.247.203:BGP route GR timeout: neighbor fc00::2d (ASN 4200065100)", 
    "FAILED:10.64.247.202:BGP route GR timeout: neighbor fc00::29 (ASN 4200065100)", 
    "FAILED:10.64.247.202:BGP route GR timeout: neighbor 10.0.0.36 (ASN 4200065100)", 
    "FAILED:10.64.247.201:BGP route GR timeout: neighbor 10.0.0.34 (ASN 4200065100)", 
    "FAILED:10.64.247.201:BGP route GR timeout: neighbor fc00::25 (ASN 4200065100)", 
    "FAILED:10.64.247.200:BGP route GR timeout: neighbor fc00::21 (ASN 4200065100)", 
    "FAILED:10.64.247.200:BGP route GR timeout: neighbor 10.0.0.32 (ASN 4200065100)",

pavel-shirshov
pavel-shirshov reviewed Feb 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

pavel-shirshov
pavel-shirshov approved these changes Feb 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@yxieca yxieca merged commit e1a46f6 into master Feb 12, 2019
@yxieca yxieca deleted the bgp_gr_timeout branch February 12, 2019 19:47
yxieca added a commit that referenced this pull request Feb 12, 2019
@yxieca
[warm/fast reboot] fail fast/warm reboot test if BGP GR timeout is de…
fe8615b 
…tected (#805)

* [warm/fast reboot] fail fast/warm reboot test if BGP GR timeout is detected

Signed-off-by: Ying Xie <[email protected]>

* [warm/fast reboot] get the actual ASN for printing

Signed-off-by: Ying Xie <[email protected]>
@anshuv-mfst anshuv-mfst mentioned this pull request Jul 21, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

1 more reviewer

@pavel-shirshov pavel-shirshov pavel-shirshov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement Included in 201811 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yxieca @pavel-shirshov