Skip to content

[Nvidia] Fix test_check_sfp_eeprom_with_option_dom issue due to some keys are not supported for OSFP 8X Pluggable Transceiver #8043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JibinBao wants to merge 1 commit into from
Closed

[Nvidia] Fix test_check_sfp_eeprom_with_option_dom issue due to some keys are not supported for OSFP 8X Pluggable Transceiver #8043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/platform_tests/mellanox/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@ def check_sfp_eeprom_info(duthost, sfp_eeprom_info, is_support_dom, show_eeprom_
["Application Advertisement", "ChannelThresholdValues", "ModuleThresholdValues"])
expected_keys = expected_keys - excluded_keys

if "Identifier" in sfp_eeprom_info and sfp_eeprom_info["Identifier"] == "SFP/SFP+/SFP28":
sfp_type_for_excluded_monitor_threshold_key = ["SFP/SFP+/SFP28", "OSFP 8X Pluggable Transceiver"]
Copy link
Contributor

@prgeor prgeor May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JibinBao can you point me to the spec where OSFP does not support channel threshold values?

Copy link
Contributor Author

@JibinBao JibinBao May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the output doesn't include the four keys, I skip checking them.
I have checked it with @keboliu. We think for passive cable it should not include the four keys, otherwise, it should include.
So, we can change the above code to skip check these keys if the cable is a passive cable. Is it ok?

Copy link
Contributor

@prgeor prgeor May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JibinBao yes we should skip checking for channel monitor values for DAC cables

Copy link
Contributor Author

@JibinBao JibinBao May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Will update it

Copy link
Contributor Author

@JibinBao JibinBao May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prgeor
We have one issue currently: sonic-net/sonic-buildimage#14602
Maybe after the issue is fixed or the design is figured out, we can change it accordingly.

if "Identifier" in sfp_eeprom_info and sfp_eeprom_info["Identifier"] in sfp_type_for_excluded_monitor_threshold_key:
excluded_keys = excluded_keys | {"ChannelMonitorValues", "ChannelThresholdValues", "ModuleMonitorValues",
"ModuleThresholdValues"}
expected_keys = (expected_keys | {
Expand Down