Fix a wrong comment in qos_sai_base.py#7965
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Apr 13, 2023
Merged
Conversation
6 tasks
tests/qos/qos_sai_base.py
Outdated
Collaborator
There was a problem hiding this comment.
why no space here while on all other places we do have ' = '?
Contributor
Author
There was a problem hiding this comment.
Hi Liat, this is the default value defination of the function argument, no space is required here. Others are the variable assignments, spaces are required.
wangxin
previously approved these changes
Apr 10, 2023
Collaborator
|
Hi @congh-nvidia, can you do a rebase to resolve the merge conflicts? |
There was a wrongly commented out line, remove the comment. Change-Id: Iedf11514599b9b4f80f03d754ad4fe9b6900f71d
congh-nvidia
force-pushed
the
qos_sai_base
branch
from
49115a5 to
45fc981
Compare
Contributor
Author
Hi @wangxin, I have rebased and fixed the conflicts, please review. Thanks. |
liat-grozovik
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
There was a wrongly commented out line(line 15) which was introduced by a typo in the PR #6869.
The test was not broken because the fixtures are also imported in the pytest plugin, but still, we need to explicitly import them in the test.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix a wrong comment introduced by PR #6869.
How did you do it?
Remove the comment and fix the the pre-commit failures.
How did you verify/test it?
By automation.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation