rename eos login/password variable name for clarity#793
Merged
lguohan merged 3 commits intosonic-net:masterfrom Jan 30, 2019
Merged
rename eos login/password variable name for clarity#793lguohan merged 3 commits intosonic-net:masterfrom
lguohan merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Guohan Lu <gulv@microsoft.com>
Signed-off-by: Guohan Lu <gulv@microsoft.com>
…t roles Signed-off-by: Guohan Lu <gulv@microsoft.com>
yxieca
approved these changes
Jan 30, 2019
deerao02
pushed a commit
to deerao02/sonic-mgmt
that referenced
this pull request
Dec 18, 2025
…mbers on Broadcom (sonic-net#793) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) https://github.com/aristanetworks/sonic-qual.msft/issues/629 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202412 - [x] 202505 ### Approach #### What is the motivation for this PR? The `drop_packets` tests were intermittently failing on certain Broadcom platforms. The root cause was identified as the test selecting interfaces where the FEC counters are not functional. #### How did you do it? Update the `rif_members` construction logic. The logic for populating `rif_members` was modified to check the `minigraph_neighbors` for each interface. If an interface's neighbor device name contains the string "PT0", it is excluded from the list of potential test interfaces. #### How did you verify/test it? Run the `drop_packets` test suite on an affected Broadcom platform and confirmed that the tests now consistently pass by avoiding the problematic interfaces. The test continues to function correctly on other platforms where this issue is not present. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[config] Add 'config interface mtu' command sonic-net#793 add fec configuration 'config interface fec [OPTIONS] <interface_name> <interface_fec>' sonic-net#764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu gulv@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation