Skip to content

[Test case] Fix test_authorization does not wait long enough before running 'show aaa'#7834

Merged
lerry-lee merged 2 commits intosonic-net:masterfrom
lerry-lee:fix_test_authorization
Mar 23, 2023
Merged

[Test case] Fix test_authorization does not wait long enough before running 'show aaa'#7834
lerry-lee merged 2 commits intosonic-net:masterfrom
lerry-lee:fix_test_authorization

Conversation

@lerry-lee
Copy link
Contributor

Description of PR

Fix test_authorization does not wait long enough before running show aaa.
Signed-off-by: Chun'ang Li chunangli@microsoft.com

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Fix test_authorization does not wait long enough before running show aaa.

How did you do it?

Use wait_until to run show aaa, remove time.sleep before checking it.

How did you verify/test it?

Run TC and TC passed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/tacacs/test_authorization.py:3:1: F401 'time' imported but unused

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@lerry-lee lerry-lee merged commit e133568 into sonic-net:master Mar 23, 2023
@lerry-lee lerry-lee deleted the fix_test_authorization branch March 23, 2023 09:09
wangxin pushed a commit that referenced this pull request Mar 24, 2023
…unning 'show aaa' (#7834)

What is the motivation for this PR?
Fix test_authorization does not wait long enough before running show aaa.

How did you do it?
Use wait_until to run show aaa, remove time.sleep before checking it.

How did you verify/test it?
Run TC and TC passed.

Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
wangxin pushed a commit that referenced this pull request Mar 24, 2023
…unning 'show aaa' (#7834)

What is the motivation for this PR?
Fix test_authorization does not wait long enough before running show aaa.

How did you do it?
Use wait_until to run show aaa, remove time.sleep before checking it.

How did you verify/test it?
Run TC and TC passed.

Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants