[advanced-reboot] Check OS version at runtime during upgrade path tests#7761
Merged
vaibhavhd merged 1 commit intosonic-net:masterfrom Mar 16, 2023
Merged
Conversation
kellyyeh
approved these changes
Mar 16, 2023
wangxin
pushed a commit
that referenced
this pull request
Mar 17, 2023
…ts (#7761) What is the motivation for this PR? During upgrade path, regex picking should be done based on the version currently running on the device. This bug has created issues in 201911 to 202205 upgrade path, where for post upgrade timing collection the test picks 201911 regex. How did you do it? Fix this by checking the current running version to select that version's regex for timing data collection. How did you verify/test it? Tested on a physical device.
wangxin
pushed a commit
that referenced
this pull request
Mar 17, 2023
…ts (#7761) What is the motivation for this PR? During upgrade path, regex picking should be done based on the version currently running on the device. This bug has created issues in 201911 to 202205 upgrade path, where for post upgrade timing collection the test picks 201911 regex. How did you do it? Fix this by checking the current running version to select that version's regex for timing data collection. How did you verify/test it? Tested on a physical device.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix bug where regex set is selected for the base image, rather than target image for the upgrade path testcase
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
During upgrade path, regex picking should be done based on the version currently running on the device.
This bug has created issues in 201911 to 202205 upgrade path, where for post upgrade timing collection the test picks 201911 regex.
How did you do it?
Fix this by checking the current running version to select that version's regex for timing data collection.
How did you verify/test it?
Tested on a physical device.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation