[dualtor] Igmore mux not running error in heartbeat failure testcases#7682
Merged
lolyu merged 1 commit intosonic-net:masterfrom Mar 8, 2023
Merged
[dualtor] Igmore mux not running error in heartbeat failure testcases#7682lolyu merged 1 commit intosonic-net:masterfrom
lolyu merged 1 commit intosonic-net:masterfrom
Conversation
As mux is stopped in heartbeat failure testcases, the error from monit about mux is not running is expected. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
lolyu
changed the title
ZhaohuiS
approved these changes
Mar 8, 2023
wangxin
pushed a commit
that referenced
this pull request
Mar 9, 2023
…#7682) Approach What is the motivation for this PR? As mux is stopped in heartbeat failure testcases, the error from monit about mux is not running is expected. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? Add the error msg to the loganalyzer ignore list. How did you verify/test it? Run test_active_tor_heartbeat_failure_upstream
wangxin
pushed a commit
that referenced
this pull request
Mar 9, 2023
…#7682) Approach What is the motivation for this PR? As mux is stopped in heartbeat failure testcases, the error from monit about mux is not running is expected. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? Add the error msg to the loganalyzer ignore list. How did you verify/test it? Run test_active_tor_heartbeat_failure_upstream
zjswhhh
reviewed
Mar 16, 2023
| ] | ||
|
|
||
|
|
||
| @pytest.mark.enable_active_active |
Contributor
There was a problem hiding this comment.
Hi @lolyu - why is enable_active_active mark removed for this test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
As mux is stopped in heartbeat failure testcases, the error from monit
about mux is not running is expected.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
How did you do it?
Add the error msg to the
loganalyzerignore list.How did you verify/test it?
Run
test_active_tor_heartbeat_failure_upstreamAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation