Skip to content

New T0 LAG topo with 8 uplinks (2 ports per LAG)#7673

Merged
developfast merged 2 commits intosonic-net:masterfrom
developfast:dojha/t0-lag-topo
Mar 14, 2023
Merged

New T0 LAG topo with 8 uplinks (2 ports per LAG)#7673
developfast merged 2 commits intosonic-net:masterfrom
developfast:dojha/t0-lag-topo

Conversation

@developfast
Copy link
Contributor

Description of PR

Summary: New T0 LAG topo (2 links per LAG) template with 8 up links (LAGs).

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

We need to deploy a new T0 LAG topology with 8 up links (LAGs) in the lab - 2 ports per LAG.

How did you do it?

Created a new T0 topo yml file, as well as a leaf template for the 8 EOS uplinks.

How did you verify/test it?

Ran add-topo successfully on a Mellanox SN2700 using ceos, and all 8 uplinks come up with bgp connections paired successfully.

admin@str2-msn2700-spy-1:~$ show int st 

     Interface            Lanes    Speed    MTU    FEC    Alias            Vlan    Oper    Admin             Type    Asym PFC 

--------------  ---------------  -------  -----  -----  -------  --------------  ------  -------  ---------------  ---------- 

     Ethernet0          0,1,2,3     100G   9100     rs     etp1          routed    down     down  QSFP28 or later         off 

     Ethernet4          4,5,6,7     100G   9100     rs     etp2           trunk      up       up  QSFP28 or later         off 

     Ethernet8        8,9,10,11     100G   9100     rs     etp3           trunk      up       up  QSFP28 or later         off 

    Ethernet12      12,13,14,15     100G   9100     rs     etp4           trunk      up       up  QSFP28 or later         off 

    Ethernet16      16,17,18,19     100G   9100     rs     etp5  PortChannel105      up       up  QSFP28 or later         off 

    Ethernet20      20,21,22,23     100G   9100     rs     etp6  PortChannel105      up       up  QSFP28 or later         off 

    Ethernet24      24,25,26,27     100G   9100     rs     etp7  PortChannel101      up       up  QSFP28 or later         off 

    Ethernet28      28,29,30,31     100G   9100     rs     etp8  PortChannel101      up       up  QSFP28 or later         off 

    Ethernet32      32,33,34,35     100G   9100     rs     etp9  PortChannel102      up       up  QSFP28 or later         off 

    Ethernet36      36,37,38,39     100G   9100     rs    etp10  PortChannel102      up       up  QSFP28 or later         off 

    Ethernet40      40,41,42,43     100G   9100     rs    etp11  PortChannel106      up       up  QSFP28 or later         off 

    Ethernet44      44,45,46,47     100G   9100     rs    etp12  PortChannel106      up       up  QSFP28 or later         off 

    Ethernet48      48,49,50,51     100G   9100     rs    etp13           trunk      up       up  QSFP28 or later         off 

    Ethernet52      52,53,54,55     100G   9100     rs    etp14           trunk      up       up  QSFP28 or later         off 

    Ethernet56      56,57,58,59     100G   9100     rs    etp15           trunk      up       up  QSFP28 or later         off 

    Ethernet60      60,61,62,63     100G   9100     rs    etp16           trunk      up       up  QSFP28 or later         off 

    Ethernet64      64,65,66,67     100G   9100     rs    etp17           trunk      up       up  QSFP28 or later         off 

    Ethernet68      68,69,70,71     100G   9100     rs    etp18           trunk      up       up  QSFP28 or later         off 

    Ethernet72      72,73,74,75     100G   9100     rs    etp19           trunk      up       up  QSFP28 or later         off 

    Ethernet76      76,77,78,79     100G   9100     rs    etp20           trunk      up       up  QSFP28 or later         off 

    Ethernet80      80,81,82,83     100G   9100     rs    etp21  PortChannel107      up       up  QSFP28 or later         off 

    Ethernet84      84,85,86,87     100G   9100     rs    etp22  PortChannel107      up       up  QSFP28 or later         off 

    Ethernet88      88,89,90,91     100G   9100     rs    etp23  PortChannel103      up       up  QSFP28 or later         off 

    Ethernet92      92,93,94,95     100G   9100     rs    etp24  PortChannel103      up       up  QSFP28 or later         off 

    Ethernet96      96,97,98,99     100G   9100     rs    etp25  PortChannel104      up       up  QSFP28 or later         off 

   Ethernet100  100,101,102,103     100G   9100     rs    etp26  PortChannel104      up       up  QSFP28 or later         off 

   Ethernet104  104,105,106,107     100G   9100     rs    etp27  PortChannel108      up       up  QSFP28 or later         off 

   Ethernet108  108,109,110,111     100G   9100     rs    etp28  PortChannel108      up       up  QSFP28 or later         off 

   Ethernet112  112,113,114,115     100G   9100     rs    etp29           trunk      up       up  QSFP28 or later         off 

   Ethernet116  116,117,118,119     100G   9100     rs    etp30           trunk      up       up  QSFP28 or later         off 

   Ethernet120  120,121,122,123     100G   9100     rs    etp31           trunk      up       up  QSFP28 or later         off 

   Ethernet124  124,125,126,127     100G   9100     rs    etp32           trunk      up       up  QSFP28 or later         off 

PortChannel101              N/A     200G   9100    N/A      N/A          routed      up       up              N/A         N/A 

PortChannel102              N/A     200G   9100    N/A      N/A          routed      up       up              N/A         N/A 

PortChannel103              N/A     200G   9100    N/A      N/A          routed      up       up              N/A         N/A 

PortChannel104              N/A     200G   9100    N/A      N/A          routed      up       up              N/A         N/A 

PortChannel105              N/A     200G   9100    N/A      N/A          routed      up       up              N/A         N/A 

PortChannel106              N/A     200G   9100    N/A      N/A          routed      up       up              N/A         N/A 

PortChannel107              N/A     200G   9100    N/A      N/A          routed      up       up              N/A         N/A 

PortChannel108              N/A     200G   9100    N/A      N/A          routed      up       up              N/A         N/A 
admin@str2-msn2700-spy-1:~$ show ip bgp sum 

  

IPv4 Unicast Summary: 

BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0 

BGP table version 12777 

RIB entries 12817, using 2358328 bytes of memory 

Peers 8, using 5926464 KiB of memory 

Peer groups 4, using 256 bytes of memory 

  

  

Neighbhor      V     AS    MsgRcvd    MsgSent    TblVer    InQ    OutQ  Up/Down      State/PfxRcd  NeighborName 

-----------  ---  -----  ---------  ---------  --------  -----  ------  ---------  --------------  -------------- 

10.0.0.57      4  64600       3210       3220         0      0       0  00:03:58             6400  ARISTA01T1 

10.0.0.59      4  64601       3194       3218         0      0       0  00:03:59             6368  ARISTA02T1 

10.0.0.61      4  64602       3192       3215         0      0       0  00:03:52             6368  ARISTA03T1 

10.0.0.63      4  64603       3192       3218         0      0       0  00:03:58             6368  ARISTA04T1 

10.0.0.65      4  64604       3192       3215         0      0       0  00:03:50             6368  ARISTA05T1 

10.0.0.67      4  64605       3192       3215         0      0       0  00:03:50             6368  ARISTA06T1 

10.0.0.69      4  64606       3192       3215         0      0       0  00:03:48             6368  ARISTA07T1 

10.0.0.71      4  64607       3194       3220         0      0       0  00:03:53             6368  ARISTA08T1 

  

Total number of neighbors 8 

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wangxin
Copy link
Collaborator

wangxin commented Mar 7, 2023

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing ansible/vars/topo_t0-8-lag.yml

fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

neethajohn
neethajohn previously approved these changes Mar 8, 2023
@neethajohn
Copy link
Contributor

@developfast , Please cleanup the errors in the pre-commit check before merge

@developfast developfast merged commit 2d3d85c into sonic-net:master Mar 14, 2023
developfast added a commit that referenced this pull request Mar 14, 2023
* added t0 lag topo filwith 8 LAG uplinks and eos leaf template
developfast added a commit that referenced this pull request Mar 14, 2023
* added t0 lag topo filwith 8 LAG uplinks and eos leaf template
developfast added a commit that referenced this pull request Mar 14, 2023
* added t0 lag topo filwith 8 LAG uplinks and eos leaf template
wangxin pushed a commit that referenced this pull request Mar 15, 2023
* added t0 lag topo filwith 8 LAG uplinks and eos leaf template
wangxin pushed a commit that referenced this pull request Mar 15, 2023
* added t0 lag topo filwith 8 LAG uplinks and eos leaf template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants