Add support of using lab tacacs server by default#7624
Merged
wangxin merged 4 commits intosonic-net:masterfrom Mar 3, 2023
Merged
Add support of using lab tacacs server by default#7624wangxin merged 4 commits intosonic-net:masterfrom
wangxin merged 4 commits intosonic-net:masterfrom
Conversation
The current default configuration of DUTs does not support using lab tacacs server for authentication. This change added a new variable `tacacs_enabled_by_default` in group_vars file to control enablement of lab tacacs server. The ansible playbook for deploy minigraph was updated to support configuring lab tacacs server based on value of this variable. The tacacs test scripts are updated to support recover the lab tacacs server in a clean way after test is done. Signed-off-by: Xin Wang <[email protected]>
yutongzhang-microsoft
approved these changes
Mar 3, 2023
wangxin
added a commit
that referenced
this pull request
Mar 6, 2023
What is the motivation for this PR? The current default configuration of DUTs does not support using lab tacacs server for authentication. This change added a new variable tacacs_enabled_by_default in group_vars file to control enablement of lab tacacs server. How did you do it? The ansible playbook for deploy minigraph was updated to support configuring lab tacacs server based on value of this variable. The tacacs test scripts are updated to support recover the lab tacacs server in a clean way after test is done. How did you verify/test it? Test run the tacacs scripts. Signed-off-by: Xin Wang <[email protected]>
wangxin
added a commit
that referenced
this pull request
Mar 7, 2023
What is the motivation for this PR? The current default configuration of DUTs does not support using lab tacacs server for authentication. This change added a new variable tacacs_enabled_by_default in group_vars file to control enablement of lab tacacs server. How did you do it? The ansible playbook for deploy minigraph was updated to support configuring lab tacacs server based on value of this variable. The tacacs test scripts are updated to support recover the lab tacacs server in a clean way after test is done. How did you verify/test it? Test run the tacacs scripts. Signed-off-by: Xin Wang <[email protected]>
bingwang-ms
pushed a commit
to bingwang-ms/sonic-mgmt
that referenced
this pull request
Jul 27, 2023
Enable TACACS for SONiC DUTs in starlab PR sonic-net#7624 added support of enabling tacacs for lab DUTs by default. This change updated the inventory variable files for starlab devices to enable TACACS by default. Signed-off-by: Xin Wang <[email protected]>
ZhaohuiS
pushed a commit
to ZhaohuiS/sonic-mgmt
that referenced
this pull request
Aug 18, 2023
Enable TACACS for SONiC DUTs in starlab PR sonic-net#7624 added support of enabling tacacs for lab DUTs by default. This change updated the inventory variable files for starlab devices to enable TACACS by default. Signed-off-by: Xin Wang <[email protected]>
StormLiangMS
pushed a commit
to StormLiangMS/sonic-mgmt
that referenced
this pull request
Dec 16, 2023
Enable TACACS for SONiC DUTs in starlab PR sonic-net#7624 added support of enabling tacacs for lab DUTs by default. This change updated the inventory variable files for starlab devices to enable TACACS by default. Signed-off-by: Xin Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The current default configuration of DUTs does not support using lab tacacs server for authentication.
This change added a new variable
tacacs_enabled_by_defaultin group_vars file to control enablement of lab tacacs server.How did you do it?
The ansible playbook for deploy minigraph was updated to support configuring lab tacacs server based on value of this variable.
The tacacs test scripts are updated to support recover the lab tacacs server in a clean way after test is done.
How did you verify/test it?
Test run the tacacs scripts.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation