Add regex for syslog timestamp in extract_log#7597
Add regex for syslog timestamp in extract_log#7597kellyyeh merged 2 commits intosonic-net:masterfrom
Conversation
4d8c303 to
8b10aec
Compare
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
| else: | ||
| return int(ns[0]) | ||
|
|
||
|
|
There was a problem hiding this comment.
Minor: two places where line breaks are removed. Double line break is a pip8 suggested format.
vaibhavhd
left a comment
There was a problem hiding this comment.
LGTM. Please mention how this change was tested.
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Updated testing |
|
Cherry-pick PR to 202205: #8675 |
|
Cherry-pick PR to 202012: #8676 |
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Warm-reboot test is failing at extracting timestamp from syslog
How did you do it?
Add regex for this timestamp format: 2023-02-28T15:42:27.355561+00:00
How did you verify/test it?
Warm reboot test originally failed at preboot when parsing through syslog. Adding the regex fixed the failure.
Ran convert_date with all three formats of syslog timestamp logs
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation