Stop exabgp processes before remove PTF container (for both old and new exabgp process naming convention)#7587
Merged
lizhijianrd merged 2 commits intosonic-net:masterfrom Feb 28, 2023
lizhijianrd:fix-remove-topo-0227
Merged
Stop exabgp processes before remove PTF container (for both old and new exabgp process naming convention)#7587lizhijianrd merged 2 commits intosonic-net:masterfrom lizhijianrd:fix-remove-topo-0227
lizhijianrd merged 2 commits intosonic-net:masterfrom
lizhijianrd:fix-remove-topo-0227
Conversation
Add ignore_errors in case of exabgp processes not exists
wangxin
approved these changes
Feb 28, 2023
wangxin
pushed a commit
that referenced
this pull request
Feb 28, 2023
…ew exabgp process naming convention) (#7587) What is the motivation for this PR? While removing topo of a testbed, we have to ensure that all the exabgp processes are stopped before PTF container be removed: * For old naming convention, exabgp processes are named like exabgp-ARISTA01T0 and exabgp-ARISTA01T0-v6. * For new naming convention, exabgp processes are named like exabgpv4:exabgp-ARISTA01T0 and exabgpv6:exabgp-ARISTA01T0-v6. In this PR, I added some check to ensure both type of exabgp processes are stopped. How did you do it? 1. For the new naming convention, use ansible supervisor module to stop process group exabgpv4 and exabgpv6. 2. For the old naming convention, use exabgp.py library to stop processes one by one. How did you verify/test it? Verified on both type of PTF containers. Signed-off-by: Zhijian Li <[email protected]>
wangxin
pushed a commit
that referenced
this pull request
Feb 28, 2023
…ew exabgp process naming convention) (#7587) What is the motivation for this PR? While removing topo of a testbed, we have to ensure that all the exabgp processes are stopped before PTF container be removed: * For old naming convention, exabgp processes are named like exabgp-ARISTA01T0 and exabgp-ARISTA01T0-v6. * For new naming convention, exabgp processes are named like exabgpv4:exabgp-ARISTA01T0 and exabgpv6:exabgp-ARISTA01T0-v6. In this PR, I added some check to ensure both type of exabgp processes are stopped. How did you do it? 1. For the new naming convention, use ansible supervisor module to stop process group exabgpv4 and exabgpv6. 2. For the old naming convention, use exabgp.py library to stop processes one by one. How did you verify/test it? Verified on both type of PTF containers. Signed-off-by: Zhijian Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
While removing topo of a testbed, we have to ensure that all the
exabgpprocesses are stopped before PTF container be removed:exabgp-ARISTA01T0andexabgp-ARISTA01T0-v6.exabgpv4:exabgp-ARISTA01T0andexabgpv6:exabgp-ARISTA01T0-v6.In this PR, I added some check to ensure both type of
exabgpprocesses are stopped.Type of change
Back port request
Approach
What is the motivation for this PR?
Ensure all the
exabgpprocesses are stopped before PTF container be removed.How did you do it?
supervisormodule to stop process groupexabgpv4andexabgpv6.exabgp.pylibrary to stop processes one by one.How did you verify/test it?
Verified on both type of PTF containers.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation