Skip to content

Fix parse_portstat to return only port info#7561

Closed
ysmanman wants to merge 1 commit intosonic-net:masterfrom
ysmanman:fix-portstat-test
Closed

Fix parse_portstat to return only port info#7561
ysmanman wants to merge 1 commit intosonic-net:masterfrom
ysmanman:fix-portstat-test

Conversation

@ysmanman
Copy link
Contributor

Description of PR

parse_portstat does not parse the output of portstat correctly and returns non port info, which fails sonic-mgmt tests #7560. The PR is to fix parse_portstat to only return port info by validating the port name.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • [ x] Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • [ x] 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wangxin
Copy link
Collaborator

wangxin commented Feb 24, 2023

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/portstat_utilities.py:69:25: E261 at least two spaces before inline comment
tests/common/portstat_utilities.py:78:40: E201 whitespace after '('
tests/common/portstat_utilities.py:78:51: E202 whitespace before ')'

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@wenyiz2021
Copy link
Contributor

closing this PR as #7537 already fixed the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants