[config reload]Modifying config reload tests to align with latest config reload enhancement#7558
Conversation
…fig reload enhancement Change-Id: I69203b17b392da28d21c750b28f0038d1dd5700d
| if int(out['stdout'].strip()) < 120: | ||
| return False | ||
|
|
||
| logging.info("Checking if delayed services are up") |
There was a problem hiding this comment.
@qiluo-msft No. But the waiting for swss for 120 seconds should cover this as well.
There was a problem hiding this comment.
Originally the test verify lldp/pmon/snmp/telemetry/etc started. I do not understand "waiting for swss for 120 seconds should cover this".
There was a problem hiding this comment.
Previously all these services took 3 min 30 seconds to boot up and hence it is greater than 120 seconds wait for swss. Now these services almost within 30 seconds of switch initialization (at the worst a min). So essentially config reload will not proceed for another 60 seconds which is quite sufficient for these services to start.
Hence not adding any checks here.
|
/azpw run Azure.sonic-mgmt |
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 participants
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Modifying config reload tests to align with latest config reload enhancement according to HLD sonic-net/SONiC#1203
How did you do it?
Removed the timer based checks
How did you verify/test it?
Run the tests with config reload enhamcenet changes
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation