Add data plane test in stress acl script by xwjiang-ms · Pull Request #7549 · sonic-net/sonic-mgmt

xwjiang-ms · 2023-02-23T05:43:22Z

Description of PR

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911
202012
202205

Approach

What is the motivation for this PR?

Stress acl test will continuously add/delete acl rules by writing config db, but the action is asynchronous with asic, that may cause some timing issue like #7396

How did you do it?

The purpose of this testcase is to test stability when add/delete acl rules, not to test responding speed, so add data plane test in this case.
Data plane test will increase test time, so reduce loop times, will run confident in weekend nightly test.

How did you verify/test it?

Run tests

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR? Stress acl test will continuously add/delete acl rules by writing config db, but the action is asynchronous with asic, that may cause some timing issue like sonic-net#7396 How did you do it? The purpose of this testcase is to test stability when add/delete acl rules, not to test responding speed, so add data plane test in this case. Data plane test will increase test time, so reduce loop times, will run confident in weekend nightly test. How did you verify/test it? Run tests Any platform specific information? Supported testbed topology if it's a new test case?

tests/acl/test_stress_acl.py

bingwang-ms · 2023-02-23T16:57:20Z

The current testing logic is always add ACL rules, and then removing them all. Can we also add a scenario, where we delete some of the existing rules, and then append some rules? It's because we never clear all rules in production. We are always deleting/updating/appending. Thanks

2. Fix other comments

xwjiang-ms · 2023-02-28T09:19:08Z

The current testing logic is always add ACL rules, and then removing them all. Can we also add a scenario, where we delete some of the existing rules, and then append some rules? It's because we never clear all rules in production. We are always deleting/updating/appending. Thanks

@bingwang-ms Can't use "sonic-cfggen" to add json string, can only use json file, so delete a random acl rule, and add one behind previous rules.

tests/acl/test_stress_acl.py

* Add data plane test in stress acl script What is the motivation for this PR? Stress acl test will continuously add/delete acl rules by writing config db, but the action is asynchronous with asic, that may cause some timing issue like #7396 How did you do it? The purpose of this testcase is to test stability when add/delete acl rules, not to test responding speed, so add data plane test in this case. Data plane test will increase test time, so reduce loop times, will run confident in weekend nightly test. How did you verify/test it? Run tests Any platform specific information? Supported testbed topology if it's a new test case?

bingwang-ms reviewed Feb 23, 2023

View reviewed changes