show counter for port, pg, queue, when ptftest enter, exit and exception#7541
Merged
XuChen-MSFT merged 2 commits intosonic-net:202012from Mar 1, 2023
Merged
Conversation
XuChen-MSFT
force-pushed
the
xuchen3/202012/show-stats
branch
from
3e8df5b to
e5690b1
Compare
Contributor
Author
|
sample output for normally exit ptf test: |
Contributor
Author
|
sample output for abnormally exit ptftest |
tests/saitests/sai_qos_tests.py
Outdated
Collaborator
There was a problem hiding this comment.
should we use wait_till other than sleep?
tests/saitests/sai_qos_tests.py
Outdated
Collaborator
There was a problem hiding this comment.
there are many repeated code snippet like this, could we put them into a func and call the func in each class? If there is any change later, we don't need to modify the code everywhere. @XuChen-MSFT
StormLiangMS
approved these changes
Mar 1, 2023
Collaborator
StormLiangMS
left a comment
StormLiangMS
left a comment
There was a problem hiding this comment.
Pls create issue for this one, we can revisit it later.
XuChen-MSFT
force-pushed
the
xuchen3/202012/show-stats
branch
from
4bc5419 to
5642318
Compare
Collaborator
|
This PR may cause error for some test cases, such as It's because we don't have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
add more counter value output, to increace trouleshooting capability.
How did you do it?
p.s.
commit 202012 first, and then will double commit to master and 202205
How did you verify/test it?
run all qos sai testcase to check if they are working well.
pass local test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation