Skip to content

Modified the test case to send v6 packet for ACL TABLE TYPE=MIRRORV6 …#7495

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
rajneeshaec:sonic-mgmt-everflow-per-interface-fix
Feb 21, 2023
Merged

Modified the test case to send v6 packet for ACL TABLE TYPE=MIRRORV6 …#7495
bingwang-ms merged 1 commit intosonic-net:masterfrom
rajneeshaec:sonic-mgmt-everflow-per-interface-fix

Conversation

@rajneeshaec
Copy link
Contributor

@rajneeshaec rajneeshaec commented Feb 16, 2023

…from INPUT_PORTS are mirrored

Summary:
Fixes # (issue)
Modified the test case to send v6 packet for ACL TABLE TYPE=MIRRORV6 from INPUT_PORTS are mirrored
Previously script was sending v4 packet only to test both( ACL TABLE_TYPE_MIRRORV6 and MIRROR) from INPUT_PORTS

Type of change

  • [ X] Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • [X ] 201911
  • [ X] 202012
  • [ X] 202205

How did you do it?

Modified the test script and added support to send ipv6 packets

How did you verify/test it?

Ran testcases on community TB and its passing
everflow/test_everflow_per_interface.py::test_everflow_per_interface[ipv4] PASSED
everflow/test_everflow_per_interface.py::test_everflow_per_interface[ipv6] PASSED

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

@wangxin
Copy link
Collaborator

wangxin commented Feb 16, 2023

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/everflow/test_everflow_per_interface.py

fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/everflow/test_everflow_per_interface.py

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@Blueve
Copy link
Collaborator

Blueve commented Feb 17, 2023

@bingwang-ms could you help take a look?

@bingwang-ms bingwang-ms merged commit 47f3f08 into sonic-net:master Feb 21, 2023
wangxin pushed a commit that referenced this pull request Feb 23, 2023
@wangxin
Copy link
Collaborator

wangxin commented Feb 24, 2023

@rajneeshaec Cherry picking this PR to 202012 branch has many conflicts. Can you help create a separate PR to the 202012 branch?

@rajneeshaec
Copy link
Contributor Author

Hi @wangxin,

Please find PR requested for 202012 branch

#7589

Thanks
Rajneesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants