Add wait time to verify mux status in sanity check#7422
Merged
xwjiang-ms merged 3 commits intosonic-net:masterfrom Mar 2, 2023
Merged
Add wait time to verify mux status in sanity check#7422xwjiang-ms merged 3 commits intosonic-net:masterfrom
xwjiang-ms merged 3 commits intosonic-net:masterfrom
Conversation
What is the motivation for this PR? After config reload, mux simulator needs some time to switch to correct status How did you do it? Add wait time in sanity check to verify mux status
xwjiang-ms
changed the title
lolyu
approved these changes
Mar 2, 2023
Collaborator
|
@xwjiang-ms Merging this PR to 202012 branch got conflicts. Can you create a separate PR to the 202012 branch? |
wangxin
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Add wait time to verify mux status What is the motivation for this PR? After config reload, mux simulator needs some time to switch to correct status How did you do it? Add wait time in sanity check to verify mux status
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
After config reload in one tor of dual-tor, mux simulator will be inconsistent for several seconds, that's because mux simulator needs some time to toggle to correct status.
How did you do it?
Add wait time in sanity check to verify mux status, and check mux status later.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation