Skip to content

Enhanced duts_running_config_facts() and duts_minigraph_facts() to handle when asics_present are not contnuous#7385

Merged
abdosi merged 32 commits intosonic-net:masterfrom
abdosi:copp
Feb 21, 2023
Merged

Enhanced duts_running_config_facts() and duts_minigraph_facts() to handle when asics_present are not contnuous#7385
abdosi merged 32 commits intosonic-net:masterfrom
abdosi:copp

Conversation

@abdosi
Copy link
Copy Markdown
Contributor

@abdosi abdosi commented Feb 3, 2023

What I did:
Enhanced duts_running_config_facts() and duts_minigraph_facts() to have asic_index define explictly.

Why I did:

This is needed if asics_present are not continuous (needed if we want to say skip one of the asic from testing may be some ports are not active in given topology or may be if asic in bad state)

How I verify :
Manual Verification

abdosi and others added 29 commits February 5, 2021 17:00
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
to have asic_index define explictly. This is needed if asics_present
are not continuous (needed if we want to say skip one of the asic from
testing may be some ports are not active in given topology or may be if
asic in bad state)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi abdosi requested a review from sujinmkang as a code owner February 3, 2023 01:09
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Feb 18, 2023

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/copp/test_copp.py
Fixing tests/platform_tests/test_link_down.py

fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing tests/everflow/conftest.py

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Failed
- hook id: check-ast
- exit code: 1
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Copy link
Copy Markdown
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abdosi abdosi merged commit 9ff4894 into sonic-net:master Feb 21, 2023
@abdosi abdosi deleted the copp branch February 21, 2023 17:19
wangxin pushed a commit that referenced this pull request Feb 23, 2023
…ndle when asics_present are not contnuous (#7385)

What I did:
Enhanced duts_running_config_facts() and duts_minigraph_facts() to have asic_index define explictly.

Why I did:

This is needed if asics_present are not continuous (needed if we want to say skip one of the asic from testing may be some ports are not active in given topology or may be if asic in bad state)

How I verify :
Manual Verification
wangxin pushed a commit that referenced this pull request Jun 29, 2023
What is the motivation for this PR?
Added missing changes of PR#7385 to fib_utils.py (#7670)
(cherry picked from commit f8ac5d3)

Some changes of PR #7385 were missed in fib_utils.py. We need to add the those changes for fib testcases to pass.

How did you do it?
Added the missed codes to fib_utils.py.

How did you verify/test it?
Tested fib testcases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants