Skip to content

Catch exception for test_tunnel_memory_leak and add debug info #7209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhaohuiS merged 2 commits into from
Jan 9, 2023
Merged

Catch exception for test_tunnel_memory_leak and add debug info #7209

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a87f95
Catch exception for test_tunnel_memory_leak and add debug info
ZhaohuiS Jan 8, 2023
7b73782
Fix pre-commit
ZhaohuiS Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions tests/dualtor/test_tunnel_memory_leak.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ def prepare_services(ptfhost):
ptf_t1_intf = random.choice(get_t1_ptf_ports(lower_tor_host, tbinfo))

all_servers_ips = mux_cable_server_ip(upper_tor_host)
unexpected_count = 0
expected_count = 0

with prepare_services(ptfhost):
# Get the original memeory percent before test
Expand All @@ -158,17 +160,24 @@ def prepare_services(ptfhost):
upper_tor_host, ptfhost, vmhost, tbinfo, iface,
conn_graph_facts, exp_pkt, existing=True, is_mocked=False
)
with server_traffic_monitor:
testutils.send(ptfadapter, int(ptf_t1_intf.strip("eth")), pkt, count=PACKET_COUNT)
logging.info("Sent {} packets from ptf t1 interface {} on standby TOR {}"
.format(PACKET_COUNT, ptf_t1_intf, lower_tor_host.hostname))
# Check memory usage for every operation, used for debugging if test failed
check_memory_leak(upper_tor_host)
pytest_assert(validate_neighbor_entry_exist(upper_tor_host, server_ipv4),
"The server ip {} doesn't exist in neighbor table on dut {}. \
tunnel_packet_handler isn't triggered.".format(server_ipv4, upper_tor_host.hostname))
pytest_assert(len(server_traffic_monitor.matched_packets) > 0,
"Didn't receive any expected packets for server {}.".format(server_ipv4))
try:
with server_traffic_monitor:
testutils.send(ptfadapter, int(ptf_t1_intf.strip("eth")), pkt, count=PACKET_COUNT)
logging.info("Sent {} packets from ptf t1 interface {} on standby TOR {}"
.format(PACKET_COUNT, ptf_t1_intf, lower_tor_host.hostname))
# Check memory usage for every operation, used for debugging if test failed
check_memory_leak(upper_tor_host)
pytest_assert(validate_neighbor_entry_exist(upper_tor_host, server_ipv4),
"The server ip {} doesn't exist in neighbor table on dut {}. \
tunnel_packet_handler isn't triggered.".format(server_ipv4, upper_tor_host.hostname))
except Exception as e:
logging.error("Capture exception {}, continue the process.".format(repr(e)))
if len(server_traffic_monitor.matched_packets) == 0:
logging.error("Didn't receive any expected packets for server {}.".format(server_ipv4))
unexpected_count += 1
else:
expected_count += 1
logging.info("The count of expected to receive packets: {}, unexpected count: {}.".format(expected_count, unexpected_count))
Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the count here pkts counts? @ZhaohuiS, from code, looks like it is the count how many times send PACKET_COUNT pkts. If so, the log is confusing.

Copy link
Copy Markdown
Contributor Author

@ZhaohuiS ZhaohuiS Jan 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StormLiangMS It counts the number of expected scenarios, not the received packet number, I update the comment.

# sleep 10s to wait memory usage stable, check if there is memory leak
time.sleep(10)
check_result = check_memory_leak(upper_tor_host)
Expand Down