[202012][advanced-reboot] IO path verification fixes for dualtor#7170
Merged
vaibhavhd merged 4 commits intosonic-net:202012from Jan 5, 2023
Merged
[202012][advanced-reboot] IO path verification fixes for dualtor#7170vaibhavhd merged 4 commits intosonic-net:202012from
vaibhavhd merged 4 commits intosonic-net:202012from
Conversation
kellyyeh
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Cherry pick for #6968
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Three improvements:
Present test_advanced_reboot crashes in examine_flow. This is due to packets are incorrectly matched in the code.
Additionally, added icmp_responder in the test, so that mux state is healthy during the duration of test.
Change mux config on both TORs to manual during the duration of test.
Fixes:
Identifying received packet in dualtor case -- t1->server rcvd pkt will have src MAC as vlan_mac, and server->t1 rcvd pkt will have src MAC as dut_mac
Identifying sent packet -- t1->server sent pkt will have dst MAC as dut_mac, and server->t1 sent pkt will have dst MAC as vlan_mac
How did you do it?
How did you verify/test it?
Tested on physical testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation