[pfc_wd] pfcwd command requires root privilege#714
Merged
yxieca merged 1 commit intosonic-net:masterfrom Oct 4, 2018
Merged
Conversation
Signed-off-by: Ying Xie <[email protected]>
wendani
approved these changes
Oct 4, 2018
yxieca
added a commit
that referenced
this pull request
Oct 4, 2018
Signed-off-by: Ying Xie <[email protected]>
yejianquan
pushed a commit
that referenced
this pull request
Aug 20, 2025
Description of PR Summary: Fixes #714, #18496 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Recent fix: #17411 The test was flaky before this fix (and continues to be so). When the test picks up an egress interface which happens to be a member of a LAG consisting of multiple members, only this member is stormed and some of the traffic successfully egresses out of the other LAG members leading to lesser drops than expected when PFCWD is triggered with DROP action. The proposed fix was to shut down all but one LAG members by reducing the number of min_links. But the same config on cEOS was missing therefore LAG doesn't come up after shutting down other LAG members. This is being rectified in this change for cEOS neighbors. How did you do it? The proposed fix is to change the min_link setting for the involved port channel on the cEOS side as well. How did you verify/test it? Stressed this test 10 times on dualtor-120 and t0-116 with Arista 7260CX3 platform. signed-off-by: [email protected]
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Enable DT2 on test link down Fixes # (issue) 32921769 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? this test is passing and can be enabled for dt2 topo ft2: <img width="2189" height="72" alt="image" src="https://github.com/user-attachments/assets/896148f2-062f-477a-ad3b-aada1f5a74ef" /> lt2: <img width="2353" height="100" alt="image" src="https://github.com/user-attachments/assets/77219690-5c06-402c-989f-db5fb596238e" /> #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-swss 2529d79..15652b2: > [mirrororch]: Add retry logic when deleting referenced mirror session (sonic-net#1104) Submodule src/sonic-utilities 0cfa942..c049e54: > [neighbor_advertiser]: Add sleep in setting mirror session and ACL rules (sonic-net#714) > [warm/fast reboot] continue executing when killing docker failed (sonic-net#713) > [ecnconfig] Validate input WRED parameters (sonic-net#579) Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Why I did it sonic-swss-common needs to support SWIG wrapper for go. Submodule update for sonic-swss-common Incorporates: d63130c [[CI]Install libyang from common-lib when build bullseye (sonic-net#710) bfe123e Add decorator for Yang default value. (sonic-net#713) 1d66080 Use SWIGPYTHON to improve SWIG for GO wrapper. (sonic-net#714) How I did it I have updated sonic-swss-common repo, this PR is used to update submodule. How to verify it Build image, and sonic-gnmi pipeline will verify SWIG wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ying Xie [email protected]
Approach
How did you do it?
pfcwd command now requires root privilege to execute.
How did you verify/test it?
executed local test on my dut and got pass.