[bgp] Refactor test_bgp_allow_list#7137
Merged
yaqiangz merged 1 commit intosonic-net:masterfrom Dec 30, 2022
Merged
Conversation
Collaborator
|
@StormLiangMS could you help review this change as well? |
StormLiangMS
approved these changes
Dec 30, 2022
Collaborator
StormLiangMS
left a comment
StormLiangMS
left a comment
There was a problem hiding this comment.
approved with 2 questions.
| ALLOW_LIST = { | ||
| 'BGP_ALLOWED_PREFIXES': { | ||
| 'DEPLOYMENT_ID|{}|{}'.format(DEPLOYMENT_ID, TEST_COMMUNITY): { | ||
| 'DEPLOYMENT_ID|0|{}'.format(TEST_COMMUNITY): { |
Collaborator
There was a problem hiding this comment.
why change to 0 from DEPLOYMENT_ID?
| "t0": "t1", | ||
| "t1": "t2", | ||
| "m0": "m1", | ||
| "t2": "t3" |
Collaborator
There was a problem hiding this comment.
There is no t3, upstream for t2 is wan router.
yaqiangz
added a commit
to yaqiangz/sonic-mgmt
that referenced
this pull request
Jan 3, 2023
What is the motivation for this PR? There is something confusing in current test_bgp_allow_list test. This PR is to refactor this case. How did you do it? Modify variable name Modify code structure How did you verify/test it? Run test_test_bgp_allow_list in t1 testbed. Signed-off-by: Yaqiang Zhu <[email protected]>
6 tasks
yaqiangz
added a commit
that referenced
this pull request
Jan 3, 2023
What is the motivation for this PR? Cherry-pick and resolve conflicts of this PR: #7137 There is something confusing in current test_bgp_allow_list test. This PR is to refactor this case. How did you do it? Modify variable name Modify code structure How did you verify/test it? Run test_test_bgp_allow_list in t1 testbed. Signed-off-by: Yaqiang Zhu <[email protected]>
maksymhedeon
pushed a commit
to githedgehog/sonic-mgmt
that referenced
this pull request
Jan 5, 2023
What is the motivation for this PR? Cherry-pick and resolve conflicts of this PR: sonic-net#7137 There is something confusing in current test_bgp_allow_list test. This PR is to refactor this case. How did you do it? Modify variable name Modify code structure How did you verify/test it? Run test_test_bgp_allow_list in t1 testbed. Signed-off-by: Yaqiang Zhu <[email protected]>
maksymhedeon
pushed a commit
to githedgehog/sonic-mgmt
that referenced
this pull request
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
There is something confusing in current test_bgp_allow_list test. This PR is to refactor this case. It help us to add bgp_allow_list test scenes more easily in the future
How did you do it?
How did you verify/test it?
Run test_test_bgp_allow_list in t1 testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation