Skip to content

Return empty BGP neighbors list if BGP feature is not enabled#7042

Merged
SuvarnaMeenakshi merged 2 commits intosonic-net:masterfrom
sanjair-git:bgp-facts
Jan 6, 2023
Merged

Return empty BGP neighbors list if BGP feature is not enabled#7042
SuvarnaMeenakshi merged 2 commits intosonic-net:masterfrom
sanjair-git:bgp-facts

Conversation

@sanjair-git
Copy link
Copy Markdown
Contributor

@sanjair-git sanjair-git commented Dec 15, 2022

Description of PR

Summary:
Fixes # (issue)

  • If BGP feature status is disabled on DUT, return bgp_facts with empty bgp_neighbors

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

  • To return bgp_facts with empty list of bgp_neighbors if the bgp feature state is disabled on DUT. For example, on supervisor card.

How did you do it?

  • By running command, "show feature status bgp" on DUT and if the feature state is disabled, return bgp_facts with empty bgp_neighbors list.

How did you verify/test it?

  • Tested by running 'test_bgp_fact.py' test case against supervisor card on a T2 chassis with bgp feature state as 'disabled'.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

bgp_fact_check
bgp-console.txt

Copy link
Copy Markdown
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SuvarnaMeenakshi SuvarnaMeenakshi merged commit bcacb68 into sonic-net:master Jan 6, 2023
wangxin pushed a commit that referenced this pull request Jan 6, 2023
What is the motivation for this PR?
To return bgp_facts with empty list of bgp_neighbors if the bgp feature state is disabled on DUT. For example, on supervisor card.
How did you do it?
By running command, "show feature status bgp" on DUT and if the feature state is disabled, return bgp_facts with empty bgp_neighbors list.
How did you verify/test it?
Tested by running 'test_bgp_fact.py' test case against supervisor card on a T2 chassis with bgp feature state as 'disabled'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants