Skip to content

Skipping reboot on Supervisor for Cisco 8000 distributed chassis#6991

Closed
vperumal wants to merge 2 commits intosonic-net:masterfrom
vperumal:rp_reboot_skip
Closed

Skipping reboot on Supervisor for Cisco 8000 distributed chassis#6991
vperumal wants to merge 2 commits intosonic-net:masterfrom
vperumal:rp_reboot_skip

Conversation

@vperumal
Copy link
Collaborator

@vperumal vperumal commented Dec 8, 2022

Description of PR

Skipping reboot on Supervisor for Cisco 8000 distributed chassis.

Summary:
Fixes # (issue)

Type of change

  • Fill x for your type of change.
  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Currently we are hitting an intermittent issue if Supervisor is rebooted during a test. To avoid tests to get errored out during nightly run, we are skipping reboot for supervisor node

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@vperumal vperumal requested a review from sujinmkang as a code owner December 8, 2022 04:05
@vperumal
Copy link
Collaborator Author

vperumal commented Dec 8, 2022

FYI @abdosi and @gechiang

@SuvarnaMeenakshi
Copy link
Contributor

Can we add the test cases to be skipped here: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml.
We could open a github issue and add that under condition along with platform string of supervisor.

@vperumal
Copy link
Collaborator Author

vperumal commented Dec 9, 2022

Can we add the test cases to be skipped here: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml.
We could open a github issue and add that under condition along with platform string of supervisor.

Hi @SuvarnaMeenakshi, the check for skip using test_mark_conditions happens at the start of the script even before dut is selected. It works fine in a single dut case but in case of multi-dut wherein it is randomly picked up within the testcase, test_mark_conditions does not work. Hence had to put it in each individual testcase.

@vperumal
Copy link
Collaborator Author

@abdosi , added skip for watchdog reboot here - since I closed - #6812.

Copy link
Contributor

@abdosi abdosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add close pid platforms also.

"""
dut.command("config save -y")
if dut.is_supervisor_node and dut.facts['platform'] in ['x86_64-8800_rp_o-r0']:
pytest.skip("Skip reboot for Supervisor card in Cisco 8000 distributed chassis")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this . this should not get call for supervisor.

@abdosi
Copy link
Contributor

abdosi commented Mar 6, 2023

we will not need now as reboot is working fine

@abdosi abdosi closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants